Regression in Node 17.5, Assigning a function to prototype of an Object results in a TypeError: Cannot assign to read only property 'x' of object 'y' at Object.<anonymous> #41926

Uzlopak · 2022-02-11T00:13:01Z

Version

17.5

Platform

Linux aras-Lenovo-Legion-5-17ARH05H 5.13.0-21-generic #21-Ubuntu SMP Tue Oct 19 08:59:28 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

We maintain the mongoose-project. Devs reported that node 17.5 is throwing a TypeError when using the package.
I tested it with node 17.5 and run the unit tests, and could reproduce the Error. When I test with node 17.4, there is no TypeError.
I checked the Changelog and there is no remark regarding a breaking change, nor does the changes implicate a breaking change in nodes behaviour.

So I assume that there is a Regression in node 17.5.

Maybe something with the attribute "map" is special?

Also is reported that adding "engines": { "node": ">=12.0.0 <17.5.0" }, to package.json fixes the issue.
Is there some nodejs quirk mode? Do we have to change something in our codebase to not raise this Error?

Just checkout mongoose-project, install dependencies, and run the tests under node 17.5

How often does it reproduce? Is there a required condition?

Happens always.

What is the expected behavior?

Should not throw a TypeError like it did not throw in node <= 17.4 and unit tests should pass as usual.

What do you see instead?

When running the tests we get:

TypeError: Cannot assign to read only property 'map' of object '#<QueryCursor>'
    at Object.<anonymous> (/home/aras/Workspace/mongoose/lib/cursor/QueryCursor.js:144:27)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/aras/Workspace/mongoose/lib/query.js:12:21)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/aras/Workspace/mongoose/lib/index.js:18:15)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/aras/Workspace/mongoose/index.js:9:18)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/aras/Workspace/mongoose/test/common.js:7:18)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/aras/Workspace/mongoose/test/aggregate.test.js:7:15)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:168:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:197:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:337:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at async formattedImport (/home/aras/Workspace/mongoose/node_modules/mocha/lib/nodejs/esm-utils.js:7:14)
    at async Object.exports.requireOrImport (/home/aras/Workspace/mongoose/node_modules/mocha/lib/nodejs/esm-utils.js:48:32)
    at async Object.exports.loadFilesAsync (/home/aras/Workspace/mongoose/node_modules/mocha/lib/nodejs/esm-utils.js:103:20)
    at async singleRun (/home/aras/Workspace/mongoose/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async Object.exports.handler (/home/aras/Workspace/mongoose/node_modules/mocha/lib/cli/run.js:374:5)

Additional information

No response

The text was updated successfully, but these errors were encountered:

Slayer95 · 2022-02-11T00:52:26Z

According to your docs,

A QueryCursor exposes a Streams3 interface, as well as a .next() function.

That conflicts with the fact that map() is now an iterator helper method for Node.js streams.

But... why was that method added to Node.js core as non-writable ??

Uzlopak · 2022-02-11T01:30:43Z

Maybe core-devs want to ensure that map is not overwritten for performance reasons?

Trott · 2022-02-11T07:09:18Z

@nodejs/streams

mcollina · 2022-02-11T08:28:28Z

cc @benjamingr that was my fear this could happen. Almost every time we added properties to the streams this happened.

Either we:

make all the new properties writable (preferred)
revert them in v17.x and ship them in v18

ronag · 2022-02-11T09:08:20Z

maybe 1. with a warning if one does overwrite it?

benjamingr · 2022-02-11T09:53:55Z

Making the new properties writable is a spec violation. I actually tested this with mongoose since they do weird things with streams and unfortunately missed this/didn't run into it.

I'll see if I can open a PR to fix this in mongoose too.

benjamingr · 2022-02-11T09:55:24Z

Wow mongoose's map is mutative that's so weird... hmm. Let me think about this a bit.

benjamingr · 2022-02-11T09:59:45Z

Opened a Mongoose PR Automattic/mongoose#11381

benjamingr · 2022-02-11T10:03:00Z

First of all to the users who ran into this @Slayer95 @Uzlopak I am sorry! It was obviously not my intention to cause this breakage, I actually tested with Mongoose but probably not after the defineProperty change.

But... why was that method added to Node.js core as non-writable ??

This is required for spec compliance and to pass a language-proposal test. Though note you can still override non-writable properties as shown in the PR above.

benjamingr · 2022-02-11T10:06:15Z

revert them in v17.x and ship them in v18

This is probably also fine, or make them writable in v17 but not v18

Lysak · 2022-02-11T11:38:36Z

To solve this error need to install nvm (Node Version Manager) and run nvm install --lts, nvm alias default lts/* and nvm use --lts

Uzlopak · 2022-02-11T12:30:20Z

First of all, thank you for your quick reaction. For me personally nothing changes, as I am not using bleeding edge. But I guess those who want to use bleeding edge are effected ;). But this is tbh the risk someone takes if he/she uses bleeding edge.

@benjamingr
Thank you for the PR in mongoose. Probably we should like you write in the PR, not overwrite map. Maybe this could also mean a perf. degredation, or maybe we have already perf degredations already... But this is something in mongoose-land and not in node-land.

@Lysak
I dont think that it makes sense to install LTS-version if we have a breaking change in node 17 and somebody is using node 17 on purpose.

benjamingr · 2022-02-11T12:39:25Z

Thank you for the PR in mongoose. Probably we should like you write in the PR, not overwrite map. Maybe this could also mean a perf. degredation, or maybe we have already perf degredations already... But this is something in mongoose-land and not in node-land.

For what it's worth Node.js takes the ecosystem very seriously and a breakage or performance regression in Mongoose because of a change in Node.js is definitely something we want to be aware of and to address. This is double true for breakage that causes programs to not work and even more so when the change isn't communicated in advance and labeled as semver-major.

benjamingr · 2022-02-11T14:56:32Z

A fix landed in master and will be released with the next Node.js release - sorry for the mess!

overmars86 · 2022-02-14T18:46:00Z

So shall we wait for the next release or find a temp. Solution? I need to fix it ASAP, please.

benjamingr · 2022-02-14T18:49:22Z

@overmars86 you can either run a version you build from master (of either mongoose or node) or use a different (lts) version of Node in the meantime

SergioArrighi · 2022-02-17T15:15:05Z

Hello, is there any ETA for the new release?
Thanks and best regards

PR-URL: nodejs#41931 Fixes: nodejs#41926 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

PR-URL: #41931 Fixes: #41926 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

lolo-io · 2022-02-23T08:53:34Z

Latest version 17.6.0 with the fix (#41931) is out : https://github.com/nodejs/node/releases/tag/v17.6.0
Tested it and the error is gone.

Not available in docker yet as :latest image still points to 1.17.5 but it should be available very soon.

rochdev · 2022-02-25T16:11:42Z

We're still seeing the same issue with Node 17.6.0: https://app.circleci.com/pipelines/github/DataDog/dd-trace-js/6164/workflows/aefc24ba-e863-47dc-9fc5-e0d1aca6c980/jobs/703409/steps

aduh95 · 2022-02-25T17:41:59Z

TypeError: Cannot assign to read only property 'forEach' of object '#'

Looks like we need to apply the same fix for all the new methods.

benjamingr · 2022-02-26T06:33:55Z

Ok, there is already a merged pr that did this (the one porting more test262 tests)so I suggest we keep this open until the next release

Uzlopak mentioned this issue Feb 11, 2022

QueryCursor.js is throwing an error on line 144: "TypeError: Cannot assign to read only property 'map' of object '#<QueryCursor>'" Automattic/mongoose#11377

Closed

benjamingr mentioned this issue Feb 11, 2022

stream: revert map spec compliance #41931

Merged

aduh95 closed this as completed in #41931 Feb 11, 2022

greschner added a commit to greschner/cpee-worklist that referenced this issue Feb 14, 2022

temp rollback to node 16 due to nodejs/node#41926

459298a

targos reopened this Feb 25, 2022

targos added the stream Issues and PRs related to the stream subsystem. label Feb 25, 2022

azu mentioned this issue Mar 1, 2022

2022-03-01のJS: Redux Toolkit 1.8.0、Node.js 17.6.0、CSS Cascade Layers jser/jser.github.io#964

Merged

ShogunPanda closed this as completed Apr 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Regression in Node 17.5, Assigning a function to prototype of an Object results in a TypeError: Cannot assign to read only property 'x' of object 'y' at Object.<anonymous> #41926

Regression in Node 17.5, Assigning a function to prototype of an Object results in a TypeError: Cannot assign to read only property 'x' of object 'y' at Object.<anonymous> #41926

Uzlopak commented Feb 11, 2022

Slayer95 commented Feb 11, 2022

Uzlopak commented Feb 11, 2022

Trott commented Feb 11, 2022

mcollina commented Feb 11, 2022

ronag commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

Lysak commented Feb 11, 2022 •

edited

Loading

Uzlopak commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

overmars86 commented Feb 14, 2022

benjamingr commented Feb 14, 2022

SergioArrighi commented Feb 17, 2022

lolo-io commented Feb 23, 2022 •

edited

Loading

rochdev commented Feb 25, 2022

aduh95 commented Feb 25, 2022

benjamingr commented Feb 26, 2022

Regression in Node 17.5, Assigning a function to prototype of an Object results in a TypeError: Cannot assign to read only property 'x' of object 'y' at Object.<anonymous> #41926

Regression in Node 17.5, Assigning a function to prototype of an Object results in a TypeError: Cannot assign to read only property 'x' of object 'y' at Object.<anonymous> #41926

Comments

Uzlopak commented Feb 11, 2022

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

Slayer95 commented Feb 11, 2022

Uzlopak commented Feb 11, 2022

Trott commented Feb 11, 2022

mcollina commented Feb 11, 2022

ronag commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

Lysak commented Feb 11, 2022 • edited Loading

Uzlopak commented Feb 11, 2022

benjamingr commented Feb 11, 2022

benjamingr commented Feb 11, 2022

overmars86 commented Feb 14, 2022

benjamingr commented Feb 14, 2022

SergioArrighi commented Feb 17, 2022

lolo-io commented Feb 23, 2022 • edited Loading

rochdev commented Feb 25, 2022

aduh95 commented Feb 25, 2022

benjamingr commented Feb 26, 2022

Lysak commented Feb 11, 2022 •

edited

Loading

lolo-io commented Feb 23, 2022 •

edited

Loading