Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.13.1 release proposal #30352

Merged
merged 102 commits into from
Nov 19, 2019
Merged

v12.13.1 release proposal #30352

merged 102 commits into from
Nov 19, 2019

Commits on Oct 25, 2019

  1. net: treat ENOTCONN at shutdown as success

    While it is not entirely clear why this condition is being
    triggered, it does resolve a reported bug.
    
    Fixes: #26315
    
    PR-URL: #29912
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    da58301 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. src: remove unused using declarations in worker.cc

    This commit removes unused using declarations in
    src/node_worker.cc.
    
    PR-URL: #29883
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    danbev authored and targos committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    ddbf150 View commit details
    Browse the repository at this point in the history
  2. benchmark: add benchmark for vm.createContext

    PR-URL: #29845
    Refs: #29842
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joyeecheung authored and targos committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    dcdb96c View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2019

  1. http2: fix file close error condition at respondWithFd

    Closing a FileHandle almost never fails, so it was hard to
    notice before that `stream.emit(err)` would not emit an error
    event due to the missing event name.
    
    Destroying the stream with the error seems like the right thing
    to do in that scenario.
    
    PR-URL: #29884
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    addaleax authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    5959023 View commit details
    Browse the repository at this point in the history
  2. benchmark: remove double word "then" in comments

    PR-URL: #29823
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    nschonni authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    e16e3d5 View commit details
    Browse the repository at this point in the history
  3. fs: buffer dir entries in opendir()

    Read up to 32 directory entries in one batch when `dir.readSync()`
    or `dir.read()` are called.
    
    This increases performance significantly, although it introduces
    quite a bit of edge case complexity.
    
                                                                     confidence improvement accuracy (*)    (**)    (***)
         fs/bench-opendir.js mode='async' dir='lib' n=100                  ***    155.93 %      ±30.05% ±40.34%  ±53.21%
         fs/bench-opendir.js mode='async' dir='test/parallel' n=100        ***    479.65 %      ±56.81% ±76.47% ±101.32%
         fs/bench-opendir.js mode='sync' dir='lib' n=100                           10.38 %      ±14.39% ±19.16%  ±24.96%
         fs/bench-opendir.js mode='sync' dir='test/parallel' n=100         ***     63.13 %      ±12.84% ±17.18%  ±22.58%
    
    PR-URL: #29893
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    addaleax authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    216e200 View commit details
    Browse the repository at this point in the history
  4. doc: fs dir modifications may not be reflected by dir.read

    PR-URL: #29893
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    addaleax authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    1fefd7f View commit details
    Browse the repository at this point in the history
  5. module: warn on require of .js inside type: module

    PR-URL: #29909
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    guybedford authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    2695f82 View commit details
    Browse the repository at this point in the history
  6. src: fix largepages regression

    During the addition of macOS support for large pages, a `memcpy` ended
    up under the wrong preprocessor directive. As a result, the newly
    allocated large pages were not initialized with a copy of the text
    section.
    
    Thanks to Suresh Srinivas <suresh.srinivas@intel.com>!
    
    PR-URL: #29914
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Gabriel Schulhof authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    f3115c4 View commit details
    Browse the repository at this point in the history
  7. crypto: reject public keys properly

    Fixes: #29904
    
    PR-URL: #29913
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    tniessen authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    e175d0b View commit details
    Browse the repository at this point in the history
  8. doc: fix some recent nits in fs.md

    * Fix sorting of sections.
    * Fix sorting of bottom references.
    * Wrap lines at 80 chars.
    * Fix a heading level.
    
    PR-URL: #29906
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    vsemozhetbyt authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    c66bc20 View commit details
    Browse the repository at this point in the history
  9. doc,meta: reduce npm PR wait period to one week

    The two-week wait period for merging npm releases is one of those rule
    exceptions that would be great to get rid of (in my opinion at least).
    There are too many exceptions to our rules and they tend to be scattered
    across multiple documents. People don't feel confident they know the
    rules, thus hampering both project velocity and Collaborator confidence.
    It also means I (and perhaps others?) get lots of pings about whether
    this or that can land, etc.
    
    This particular issue has come up a few times lately, and is
    specifically calling for an exception-to-the-exception so that the
    latest version of npm can be released along with Node.js 13.0.0.
    Refs: #29885 (comment)
    
    I propose here reducing the wait period from two weeks to one week. If,
    after some amount of time, there seems to be no problems caused by this
    change, we can consider further reducing the wait period to 48 hours to
    align it with all other change requests. Even if you think that is going
    too far, hopefully we can at least get it reduced to a week, as the
    second week of the waiting period is usually just the PR sitting around
    with an occasional ping from someone about whether/when it can land.
    
    PR-URL: #29922
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Trott authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    5ade490 View commit details
    Browse the repository at this point in the history
  10. domain: do not import util for a simple type check

    This removes `require('util')` from the `domain` module. There was
    only a single simple type check used from the `util` module which
    is now inlined instead.
    
    PR-URL: #29825
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    BridgeAR authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    8a333a4 View commit details
    Browse the repository at this point in the history
  11. src: render N-API weak callbacks as cleanup hooks

    Since worker threads are complete Node.js environments, including the
    ability to load native addons, and since those native addons can
    allocate resources to be freed when objects go out of scope, and since,
    upon worker thread exit, the engine does not invoke the weak callbacks
    responsible for freeing resources which still have references, this
    modification introduces tracking for weak references such that a list
    of outstanding weak references is maintained. This list is traversed
    during environment teardown. The callbacks for the remaining weak
    references are called.
    
    This change is also relevant for Node.js embedder scenarios, because in
    those cases the process also outlives the `node::Environment` and
    therefore weak callbacks should also be rendered as environment cleanup
    hooks to ensure proper cleanup after native addons. This changes
    introduces the means by which this can be accomplished.
    
    A benchmark is included which measures the time it takes to execute the
    weak reference callback for a given number of weak references.
    
    Re: tc39/proposal-weakrefs#125 (comment)
    PR-URL: #28428
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    aac2476 View commit details
    Browse the repository at this point in the history
  12. tools: port Python 3 compat patches from node-gyp to gyp

    Refs: nodejs/node-gyp#1820
    Refs: nodejs/node-gyp#1843
    
    PR-URL: #29897
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    41430be View commit details
    Browse the repository at this point in the history
  13. build: always use strings for compiler version in gyp files

    If GYP finds a string variable that can be converted to an integer,
    it will do it when the variable is expanded. Use "0.0" instead of "0"
    to force strings and be able to use comparison operations such as
    `gas_version >= "2.26"` in Python 3.
    
    PR-URL: #29897
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    8da83e8 View commit details
    Browse the repository at this point in the history
  14. tools: fix GYP MSVS solution generator for Python 3

    PR-URL: #29897
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    59033f6 View commit details
    Browse the repository at this point in the history
  15. tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE

    PR-URL: #29956
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    devsnek authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    8d03013 View commit details
    Browse the repository at this point in the history
  16. build: fix version checks in gyp files

    Make `distutils.version.StrictVersion` available as a helper to
    gyp expressions so they can do proper version checks and update
    the gyp files accordingly.
    
    Caveat emptor: `StrictVersion` does *not* like empty strings so
    this commit adds truthiness guards. The helper could deal with
    those but I felt it better to make it explicit.
    
    Fixes: #29927
    
    PR-URL: #29931
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    bnoordhuis authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    735ec1b View commit details
    Browse the repository at this point in the history
  17. process: add lineLength to source-map-cache

    Without the line lengths of in-memory transpiled source, it's not
    possible to convert from byte ofsets to line/column offsets.
    
    PR-URL: #29863
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bcoe authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    62bc80c View commit details
    Browse the repository at this point in the history
  18. test: fix fs benchmark test

    Add missing option "mode". Alphabetize options for easier maintenance.
    
    PR-URL: #29967
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Trott authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    aec8e77 View commit details
    Browse the repository at this point in the history
  19. doc: prepare miscellaneous docs for new markdown lint rules

    Prepare the final few documents that haven't been updated to always use
    `[]` with reference links and to escape `[` and `]` for things that
    aren't links in markdown files.
    
    PR-URL: #29963
    Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    a23b5cb View commit details
    Browse the repository at this point in the history
  20. test: fix flaky doctool and test

    Doctool tests have been failing a lot in CI on Win2008 R2. It appears
    async functions and callback-based functions are being used in
    combination such that the callback-based function cannot guarantee that
    it will invoke its callback. Convert the callback-based functions to
    async functions so we have one paradigm and reliable results.
    
    PR-URL: #29979
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Trott authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    b93c8a7 View commit details
    Browse the repository at this point in the history
  21. doc: add server header into the discarded list of http message.headers

    PR-URL: #29962
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Huachao authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    c0cbfae View commit details
    Browse the repository at this point in the history
  22. doc: re-enable passing remark-lint rule

    PR-URL: #29961
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    nschonni authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    12f2454 View commit details
    Browse the repository at this point in the history
  23. doc: remove unused Markdown reference links

    PR-URL: #29961
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    nschonni authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    b57fe3b View commit details
    Browse the repository at this point in the history
  24. test: add cb error test for fs.close()

    Provides some missing test coverage.
    
    PR-URL: #29970
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    teorossi82 authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    3e39909 View commit details
    Browse the repository at this point in the history
  25. src: refine maps parsing for large pages

    Multiple sections may be marked as "r-xp" and with the executable's
    path. We use the location of the `__nodetext` symbol added by the linker
    script to ensure that the range we retrieve from the maps file does
    indeed contain the Node.js text section.
    
    Thanks to Suresh Srinivas <suresh.srinivas@intel.com>!
    
    PR-URL: #29973
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Gabriel Schulhof authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    45c5ad7 View commit details
    Browse the repository at this point in the history
  26. doc: clarify readable.unshift null/EOF

    PR-URL: #29950
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    ronag authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    5616f22 View commit details
    Browse the repository at this point in the history
  27. esm: modify resolution order for specifier flag

    Currently `--es-module-specifier-resolution=node` has an alternative
    resolution order than the default in common.js, this causes
    inconsistencies. As discussed in @nodejs/modules we want to preserve
    resolution order between implementations.
    
    PR-URL: #29974
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    94ac44f View commit details
    Browse the repository at this point in the history
  28. build: build benchmark addons like test addons

    Build the addons for benchmarks in the same way that the addons for
    tests are built.
    
    PR-URL: #29995
    Fixes: nodejs/build#1961
    Refs: 53ca0b9#commitcomment-35494896
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    richardlau authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    a1adce1 View commit details
    Browse the repository at this point in the history
  29. build: fix version checks in configure.py

    Fixes: #29927
    Refs: #29931
    
    PR-URL: #29965
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    02f6e5c View commit details
    Browse the repository at this point in the history
  30. doc: fix tls version typo

    PR-URL: #29984
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    akitsu-sanae authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    d9b5508 View commit details
    Browse the repository at this point in the history
  31. test: remove common.skipIfInspectorEnabled()

    common.skipIfInspectorEnabled() is only used once in all of the tests.
    The test is more clear (in my opinion, at least) without the abstraction
    so put the check directly in the test. Additionally, it honestly looks
    like an error (which is how I noticed it in the first place) and that
    someone mistyped the far more common skipIfInspectorDisabled().
    
    PR-URL: #29993
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Trott authored and targos committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    9fed62f View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2019

  1. src: initialize openssl only once

    For compatibility with OpenSSL 1.1.0 and 1.0.1 a series of
    initialization wrappers were being called, many deprecated, and many
    calling each other internally already. Compatibility is unnecessary in
    12.x and later, which support only OpenSSL 1.1.1, and the multiple calls
    cause the configuration file to be loaded multiple times.
    
    Fixes: #29702
    
    See:
    - https://mta.openssl.org/pipermail/openssl-users/2019-October/011303.html
    - https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_init_ssl.html
    - https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_init_crypto.html
    
    PR-URL: #29999
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    sam-github authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    aa0aacb View commit details
    Browse the repository at this point in the history
  2. doc: update collaborator email address

    update collaborator email address
    
    PR-URL: #30007
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    JungMinu authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    8df5bdb View commit details
    Browse the repository at this point in the history
  3. test: fix test runner for Python 3 on Windows

    Explicitly open files with utf8 encoding, otherwise the system could use
    another encoding such as latin1 by default.
    
    PR-URL: #30023
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    2ebd1a0 View commit details
    Browse the repository at this point in the history
  4. deps: upgrade to libuv 1.33.1

    Notable changes:
    
    - uv_random() has been added.
    - More work to read those pesky Windows
      environment variables.
    - Several build fixes for Tier 3 platforms (Android,
      NetBSD, OpenBSD, Haiku).
    - Stop using fsevents to watch files (using kqueue again).
    
    PR-URL: #29996
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    cjihrig authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    2764567 View commit details
    Browse the repository at this point in the history
  5. src: remove unused iomanip include

    This commit removes the include of the IO manipulators header as I can't
    find that it is used anywhere.
    
    PR-URL: #30004
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    danbev authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    6269a3c View commit details
    Browse the repository at this point in the history
  6. src: fewer uses of NODE_USE_V8_PLATFORM

    PR-URL: #30029
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    codebytere authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    4b57088 View commit details
    Browse the repository at this point in the history
  7. test: expand Worker test for non-shared ArrayBuffer

    This test would be broken by V8 7.9 due to the changed `ArrayBuffer`
    backing store management (the same way that V8 7.8 broke this for
    `SharedArrayBuffer`s). While working on a solution, it would be
    good to already have this test in Node.js to avoid unnecessary
    accidental breakage.
    
    Refs: nodejs/node-v8#115
    
    PR-URL: #30044
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ecf6ae8 View commit details
    Browse the repository at this point in the history
  8. stream: remove dead code

    `String.prototype.split()` returns an array of strings so the branch is
    never taken.
    
    Fixes: #30040
    
    PR-URL: #30041
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    lpinca authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ae39039 View commit details
    Browse the repository at this point in the history
  9. stream: simplify uint8ArrayToBuffer helper

    The fallback code is no longer used when exporting to readable-stream.
    
    Refs: #29514
    
    PR-URL: #30041
    Fixes: #30040
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    lpinca authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    21a43bd View commit details
    Browse the repository at this point in the history
  10. doc: join parts of disrupt section in cli.md

    Also eliminate some redundancy.
    
    PR-URL: #30038
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    vsemozhetbyt authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    870c320 View commit details
    Browse the repository at this point in the history
  11. build: log the found compiler version if too old

    `configure` will log a warning if the detected compiler is not new
    enough. Take some of the guesswork out of it by also logging the
    version of the compiler that was detected.
    
    PR-URL: #30028
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    richardlau authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    a86648c View commit details
    Browse the repository at this point in the history
  12. src: expose ListNode<T>::prev_ on postmortem metadata

    Make ListNode<T> postmortem easier to find last items in the queue.
    
    PR-URL: #30027
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    legendecas authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    693bf73 View commit details
    Browse the repository at this point in the history
  13. src: make implementing CancelPendingDelayedTasks for platform optional

    Fold `CancelPendingDelayedTasks()` into `UnregisterIsolate()` and
    make implementing it optional.
    
    It makes sense for these two operations to happen at the same time,
    so it is sufficient to provide a single operation instead of two
    separate ones.
    
    PR-URL: #30034
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    addaleax authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    abfac96 View commit details
    Browse the repository at this point in the history
  14. build: make linter failures fail test-doc target

    Linter failures in the `test-doc` make target were not failing the
    build if the subsequent `doctools` test passed as its exit code
    wasn't being preserved.
    
    Make the `lint` target a dependency of `test-doc` so that it is
    outside of the `node_use_openssl` guard -- its own dependencies
    have their own guards where necessary and the targets that don't
    require an available node (e.g. the C++ linters) will be allowed
    to run.
    
    PR-URL: #30012
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    richardlau authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    032c23d View commit details
    Browse the repository at this point in the history
  15. src: remove unnecessary std::endl usage

    This commit removes a few std::endl that could be replaced by '\n' as it
    does not look like the buffer needs to be flushed in these places.
    
    This is only done in error handling, and once when the report has been
    generated, so this is very minor but I thought I'd bring it up in case
    it was overlooked.
    
    PR-URL: #30003
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    danbev authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    f6655b4 View commit details
    Browse the repository at this point in the history
  16. doc: --enable-source-maps and prepareStackTrace are incompatible

    document the fact that --enable-source-maps and prepareStackTrace are
    incompatible, see #29994
    
    PR-URL: #30046
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    bcoe authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    22e10fd View commit details
    Browse the repository at this point in the history
  17. deps: npm: patch support for 13.x

    This should keep the npm warning at bay until it is patched
    upstream.
    
    Refs: npm/cli#269
    Refs: #30066
    
    PR-URL: #30079
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    ljharb authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    58c585e View commit details
    Browse the repository at this point in the history
  18. inspector: turn platform tasks that outlive Agent into no-ops

    Turn tasks scheduled on the `v8::Isolate` or on the given platform
    into no-ops if the underlying `MainThreadInterface` has gone away
    before the task could be run (which would happen when the
    `Environment` instance and with it the `inspector::Agent` instance
    are destroyed).
    
    This addresses an issue that Electron has been having with
    inspector support, and generally just seems like the right thing
    to do, as we may not fully be in control of the relative timing
    of Environment teardown, platform tasksexecution, and the
    execution of `RequestInterrupt()` callbacks (although
    the former two always happen in the same order in our own code).
    
    PR-URL: #30031
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    4277066 View commit details
    Browse the repository at this point in the history
  19. build: python3 support for configure

    PR-URL: #30047
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    rvagg authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0415dd7 View commit details
    Browse the repository at this point in the history
  20. crypto: guard with OPENSSL_NO_GOST

    PR-URL: #30050
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    codebytere authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    b7bdfd3 View commit details
    Browse the repository at this point in the history
  21. deps: V8: cherry-pick ed40ab1

    Original commit message:
    
        [regexp] Fix the order of named captures on the groups object
    
        Named capture properties on the groups object should be ordered by the
        capture index (and not alpha-sorted). This was accidentally broken in
        https://crrev.com/c/1687413.
    
        Bug: v8:9822,v8:9423
        Change-Id: Iac6f866f077a1b7ce557ba47e8ba5d7e7014b3ce
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864829
        Auto-Submit: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Peter Marshall <petermarshall@chromium.org>
        Commit-Queue: Peter Marshall <petermarshall@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64306}
    
    Refs: v8/v8@ed40ab1
    Fixes: #29878
    
    PR-URL: #30064
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    d2756fd View commit details
    Browse the repository at this point in the history
  22. deps: V8: cherry-pick c721203

    Original commit message:
    
        Add missing null condition in Proxy GetPrototypeof
    
        Bug: v8:9781
        Change-Id: I1f82a828f103cc2aa3f9553214f6b4867ffc3b17
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829897
        Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com>
        Reviewed-by: Georg Neis <neis@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64049}
    
    Refs: v8/v8@c721203
    Fixes: #29730
    
    PR-URL: #30065
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ce49a41 View commit details
    Browse the repository at this point in the history
  23. test: verify npm compatibility with releases

    This adds a test that makes sure than running `npm` from a release does
    not print warnings to the console.
    
    PR-URL: #30082
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    00dab34 View commit details
    Browse the repository at this point in the history
  24. doc: add legendecas to collaborators

    PR-URL: #30115
    Fixes: #30000
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    legendecas authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    c4c8e01 View commit details
    Browse the repository at this point in the history
  25. src: allow inspector without v8 platform

    Embedders sometimes want to take control of V8 platform initialization
    themselves, so we wouldn't want to experience an error if
    NODE_USE_V8_PLATFORM was false necessarily. Instead, we can also gate
    it with HAVE_INSPECTOR to allow embedders to define that themselves
    and use Inspector without NODE_USE_V8_PLATFORM.
    
    PR-URL: #30049
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    codebytere authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    d586070 View commit details
    Browse the repository at this point in the history
  26. test: use arrow functions for callbacks

    Use arrow functions for callbacks in
    test/addons/make-callback-recurse/test.js.
    
    PR-URL: #30069
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    mpark86 authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    d96e8b6 View commit details
    Browse the repository at this point in the history
  27. n-api,doc: add info about building n-api addons

    Adds information about tools available for building N-API addons.
    
    Fixes: nodejs/abi-stable-node#384
    PR-URL: #30032
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    jschlight authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ee3c3ad View commit details
    Browse the repository at this point in the history
  28. async_hooks: only emit after for AsyncResource if stack not empty

    We clear the async id stack inside the uncaught exception handler and
    emit `after` events in the process, so we should not emit `after`
    a second time from the `runInAsyncScope()` code.
    
    This should match the behaviour we have in C++.
    
    Fixes: #30080
    
    PR-URL: #30087
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    addaleax authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    56be32d View commit details
    Browse the repository at this point in the history
  29. doc: remove dashes

    The use of dashes -- in general, but especially in our docs -- can be
    problematic. It is used inconsistently and there is always another form
    of punctuation that is as good or better for the situation. In an effort
    to reduce the number of variations we use to display the same types of
    information, remove the various uses of dashes from the documentation.
    
    PR-URL: #30101
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ee954d5 View commit details
    Browse the repository at this point in the history
  30. doc: delete "a number of" things in the docs

    Delete "a number of" phrases in the docs. See what I did there? Ha ha.
    Ha ha. Ha. ...heh.. <clears throat/>
    
    PR-URL: #30103
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    a56e78c View commit details
    Browse the repository at this point in the history
  31. doc,n-api: sort bottom-of-the-page references

    Use `tail -n 102 doc/api/n-api.md | LC_ALL=C sort -u` to establish a
    systematic order for the references.
    
    PR-URL: #30124
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: legendecas <legendecas@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Gabriel Schulhof authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0ec63ee View commit details
    Browse the repository at this point in the history
  32. doc: revise os.md

    Revise os.md, mostly making it more concise. In one case, process.md was
    revised as well to be consistent with a revision in os.md.
    
    PR-URL: #30102
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ec99287 View commit details
    Browse the repository at this point in the history
  33. doc: remove "it is important to" phrasing

    Instead of telling someone "It is important to do X", just tell them to
    "Do X."
    
    PR-URL: #30108
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    2ac76e3 View commit details
    Browse the repository at this point in the history
  34. tools: doc: improve async workflow of generate.js

    Use fs.promises for read and write file
    Use unified().process wich is async instead processSync
    html and json are write in parallel
    errors are logged and exit process with `1` code
    
    Fixes: #30090
    
    PR-URL: #30106
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    tpoisseau authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0b6fb3d View commit details
    Browse the repository at this point in the history
  35. doc: adjust code sample for stream.finished

    PR-URL: #29983
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    imcotton authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    c2108d4 View commit details
    Browse the repository at this point in the history
  36. doc: remove incorrect and outdated example

    PR-URL: #30138
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    tniessen authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    28db999 View commit details
    Browse the repository at this point in the history
  37. tools: update ESLint to 6.6.0

    Update ESLint to 6.6.0
    
    PR-URL: #30123
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cjihrig authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    375f349 View commit details
    Browse the repository at this point in the history
  38. stream: extract Readable.from in its own file

    See: nodejs/readable-stream#420
    
    PR-URL: #30140
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    mcollina authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    8a31136 View commit details
    Browse the repository at this point in the history
  39. src: split up InitializeContext

    This splits out code from InitializeContext into a
    new function InitializeContextForSnapshot and
    moves the callsite of InitializeContextRuntime from
    NewContext to InitializeContext - embedders don't
    necessarily call NewContext and so need to be able
    to guarantee these functions are called regardless.
    
    PR-URL: #30067
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    codebytere authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    b215b16 View commit details
    Browse the repository at this point in the history
  40. doc,meta: prefer aliases and stubs over Runtime Deprecations

    Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
    An alias or stub will have lower maintenance costs for end users.
    
    Refs: #29989 (comment)
    
    PR-URL: #30153
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Trott authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    66c6818 View commit details
    Browse the repository at this point in the history
  41. doc: fix an error in resolution algorithm steps

    As it is, if `X begins with './' or '/' or '../'` (step 3), it reads
    as if it were possible for the algorithm to do a node_modules lookup
    (step 4). But that doesn't seem to reflect the actual logic.
    
    PR-URL: #29940
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Alex Zherdev authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    d0f5bc1 View commit details
    Browse the repository at this point in the history
  42. doc: add options description for send APIs

    Describes the meaning of the boolean return in process.send()
    (doc/api/process.md) and worker.send() (doc/api/cluster.md) as
    described in subprocess.send() (doc/api/child_process.md)
    
    Fixes: #26995
    PR-URL: #29868
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    dev-script authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    98d31da View commit details
    Browse the repository at this point in the history
  43. doc: move inactive Collaborators to emeriti

    Moving some relatively inactive Collaborators to emeriti. In all cases,
    the Collaborator has been emailed and responded that they were fine with
    this change.
    
    PR-URL: #30177
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0efe9a0 View commit details
    Browse the repository at this point in the history
  44. deps: update npm to 6.12.1

    PR-URL: #30164
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Michael Perrotte authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    b88314f View commit details
    Browse the repository at this point in the history
  45. doc: improve doc Http2Session:Timeout

    Add line in doc/http2.md for 'timeout' event which tell readers
    that 'timeout' event doesn't except any arguments.
    
    Refs: nodejs/help#877
    PR-URL: #30161
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    dev-script authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    7b50474 View commit details
    Browse the repository at this point in the history
  46. build: fix pkg-config search for libnghttp2

    The configure script was searching for 'nghttp2' whereas the actual name
    of the package is 'libnghttp2'.
    
    This change also removes the hack for libcares in one fell swoop.
    
    Co-Authored-By: legendecas <legendecas@gmail.com>
    
    PR-URL: #30145
    Fixes: #30113
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    bnoordhuis authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    468f203 View commit details
    Browse the repository at this point in the history
  47. doc: update AUTHORS list

    PR-URL: #30142
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    a71f210 View commit details
    Browse the repository at this point in the history
  48. src: change env.h includes for forward declarations

    Due to how the Environment class is used through the codebase,
    there are a lot of includes referencing either env.h or env-inl.h.
    This can cause that when any development touches those libraries,
    a lot of files have to be recompiled.
    This commit attempts to change those includes by forward declarations
    when possible to mitigate the issue.
    
    Refs: #27531
    
    PR-URL: #30133
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    alferpal authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    c52b292 View commit details
    Browse the repository at this point in the history
  49. tools: git rm -r tools/v8_gypfiles/broken

    PR-URL: #30149
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    cclauss authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    df0fbf2 View commit details
    Browse the repository at this point in the history
  50. build: find Python syntax errors in dependencies

    As discussed in
    #30129 (comment), when
    we vendor in code, we own the Syntax Errors in that code.  This PR adds
    The `.flake8` config file at the root of this repo puts blinders on the
    linting of our dependencies so this test disables that file before
    linting.
    
    fixup: allow_failures until dependencies pass
    
    PR-URL: #30143
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    cclauss authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    c5d312f View commit details
    Browse the repository at this point in the history
  51. deps: V8: cherry-pick e5dbc95

    Original commit message:
    
        [api] Fix handle leak when getting Context embedder data
    
        The `Context::SlowGetAlignedPointerFromEmbedderData()` method returns
        a pointer, so the fact that it allocates handles is not obvious to
        the caller.
    
        Since this is the slow path anyway, simply add a handle scope inside
        of it.
    
        The tests are also modified to perform the same check for the
        `Object` equivalent of this method.
    
        Change-Id: I5f03c9a7b70b3a17315609df021606a53c9feb2d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879902
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64583}
    
    Refs: v8/v8@e5dbc95
    Fixes: #30127
    PR-URL: #30130
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Gabriel Schulhof authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    6bc7a6d View commit details
    Browse the repository at this point in the history
  52. tools: undefined name opts -> args in gyptest.py

    ```
    ./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
        extra_path = [os.path.abspath(p) for p in opts.path]
                                                  ^
    ```
    `opts.path` is an undefined name in this context while `args.path` is
    used on the preceding line and is defined on line 48.  Undefined names
    have the potential to raise `NameError` at runtime which will halt the
    script.
    
    PR-URL: #30144
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    cclauss authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    309c395 View commit details
    Browse the repository at this point in the history
  53. tools: use print() function in buildbot_run.py

    PR-URL: #30148
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cclauss authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    87cb6b2 View commit details
    Browse the repository at this point in the history
  54. tools: fix Python 3 syntax error in mac_tool.py

    PR-URL: #30146
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    cclauss authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    b654673 View commit details
    Browse the repository at this point in the history
  55. doc: linkify .fork() in cluster documentation

    PR-URL: #30163
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    addaleax authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    d7bfc6c View commit details
    Browse the repository at this point in the history
  56. meta: use contact_links instead of issue templates

    To redirect people to the help and website repos.
    
    PR-URL: #30172
    Refs: https://github.blog/changelog/2019-10-28-new-issue-template-configuration-options/
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    b0837fe View commit details
    Browse the repository at this point in the history
  57. src: isolate->Dispose() order consistency

    PR-URL: #30181
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    codebytere authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ab03c29 View commit details
    Browse the repository at this point in the history
  58. doc: explain http2 aborted event callback

    Line added in the description of http2 aborted event
    that it's listener does not expect any arguments.
    
    Refs: nodejs/help#877
    PR-URL: #30179
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    dev-script authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    9c4a9e7 View commit details
    Browse the repository at this point in the history
  59. doc: linkify .setupMaster() in cluster doc

    Refs: #30163
    PR-URL: #30204
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    trivikr authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    b159b91 View commit details
    Browse the repository at this point in the history
  60. doc: add missing hash for header link

    The link is to a heading in the file, but is missing the #
    
    PR-URL: #30188
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    33bd128 View commit details
    Browse the repository at this point in the history
  61. tools: fix Python 3 deprecation warning in test.py

    PR-URL: #30208
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Hellzed authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    41d1f16 View commit details
    Browse the repository at this point in the history
  62. deps: V8: cherry-pick a7dffcd767be

    Original commit message:
    
        [postmortem] Load files using utf-8 to support Python 3
    
        Change-Id: I174d38cc33210c07d1a7596627e1b2d21bb06313
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895560
        Reviewed-by: Mathias Bynens <mathias@chromium.org>
        Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
        Cr-Commit-Position: refs/heads/master@{#64717}
    
    Refs: v8/v8@a7dffcd
    
    PR-URL: #30218
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    cclauss authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    b1529c6 View commit details
    Browse the repository at this point in the history
  63. buffer: improve performance caused by primordials

    This is my first PR, and it's based on the code-and-learn guidances
    This restore some performance after introducing primordialias.
    
    Refs: #29766
    Refs: nodejs/code-and-learn#97
    Refs: #29633
    
    PR-URL: #30235
    Refs: #29766
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    jizusun authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    680e9cc View commit details
    Browse the repository at this point in the history
  64. build: add workaround for WSL

    Signed-off-by: gengjiawen <technicalcute@gmail.com>
    
    PR-URL: #30221
    Fixes: #30189
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    gengjiawen authored and targos committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    bcd2238 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. tools: update tzdata to 2019c

    Refs: #30211
    Refs: #30356
    
    PR-URL: #30478
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    MylesBorins authored and targos committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    2810f1a View commit details
    Browse the repository at this point in the history
  2. tools: pull xcode_emulation.py from node-gyp

    PR-URL: #30272
    Fixes: #30129
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    cclauss authored and targos committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    b9fd18f View commit details
    Browse the repository at this point in the history
  3. test: do not run release-npm test without crypto

    npm requires crypto support and cannot be loaded without it.
    
    PR-URL: #30265
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    56e986a View commit details
    Browse the repository at this point in the history
  4. 2019-11-19, Version 12.13.1 'Erbium' (LTS)

    Notable changes:
    
    * Experimental support for building Node.js with Python 3 is improved.
    * ICU time zone data is updated to version 2019c. This fixes the date
      offset in Brazil.
    
    PR-URL: #30352
    targos committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    525fd9c View commit details
    Browse the repository at this point in the history