Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meaning of the boolean return value of send() not documented #26995

Closed
sam-github opened this issue Mar 29, 2019 · 5 comments
Closed

meaning of the boolean return value of send() not documented #26995

sam-github opened this issue Mar 29, 2019 · 5 comments
Labels
confirmed-bug Issues with confirmed bugs. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@sam-github
Copy link
Contributor

https://nodejs.org/api/child_process.html#child_process_subprocess_send_message_sendhandle_options_callback describes the meaning of the boolean return.

It should be described in https://nodejs.org/api/cluster.html#cluster_worker_send_message_sendhandle_callback and
https://nodejs.org/api/process.html#process_process_send_message_sendhandle_options_callback but is not.

reported in #26937 (comment)

  • Version: all
  • Platform: n/a
  • Subsystem: process, cluster
@sam-github sam-github added confirmed-bug Issues with confirmed bugs. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Mar 29, 2019
@shree-y
Copy link

shree-y commented Mar 29, 2019 •
edited
Loading

Hi, I am working on this. ✋

@Drithyl
Copy link

Drithyl commented Apr 18, 2019

Has this been resolved?

@shree-y
Copy link

shree-y commented Apr 24, 2019

Has this been resolved?

@Drithyl Nope. Waiting for the reviewer to respond to my PR: #27003

shree-y added a commit to shree-y/node that referenced this issue May 24, 2019
@shree-y
doc: document the return value of {process,worker}.send()
782e702 
Add documentation for the boolean value returned by process.send()
and worker.send().

Fixes: nodejs#26995
shree-y added a commit to shree-y/node that referenced this issue May 24, 2019
@shree-y
doc: document the return value of {process,worker}.send()
9426474 
Add documentation for the boolean value returned by process.send()
and worker.send().

Fixes: nodejs#26995
shree-y added a commit to shree-y/node that referenced this issue May 24, 2019
@shree-y
doc: document the return value of {process,worker}.send()
6fccf84 
Add documentation for the boolean value returned by process.send()
and worker.send().

Fixes: nodejs#26995
@dev-script
Copy link
Contributor

Does this still need to be worked on? If so I'd like to take it.

@shree-y
Copy link

shree-y commented Oct 7, 2019

Does this still need to be worked on? If so I'd like to take it.

@dev-313 Go ahead. It's all yours!

targos pushed a commit that referenced this issue Nov 5, 2019
@dev-script @targos
doc: add options description for send APIs
a48d179 
Describes the meaning of the boolean return in process.send()
(doc/api/process.md) and worker.send() (doc/api/cluster.md) as
described in subprocess.send() (doc/api/child_process.md)

Fixes: #26995
PR-URL: #29868
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this issue Nov 8, 2019
@dev-script @targos
doc: add options description for send APIs
fee16bc 
Describes the meaning of the boolean return in process.send()
(doc/api/process.md) and worker.send() (doc/api/cluster.md) as
described in subprocess.send() (doc/api/child_process.md)

Fixes: #26995
PR-URL: #29868
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this issue Nov 10, 2019
@dev-script @targos
doc: add options description for send APIs
91e1dcf 
Describes the meaning of the boolean return in process.send()
(doc/api/process.md) and worker.send() (doc/api/cluster.md) as
described in subprocess.send() (doc/api/child_process.md)

Fixes: #26995
PR-URL: #29868
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this issue Nov 10, 2019
@dev-script @targos
doc: add options description for send APIs
7295b47 
Describes the meaning of the boolean return in process.send()
(doc/api/process.md) and worker.send() (doc/api/cluster.md) as
described in subprocess.send() (doc/api/child_process.md)

Fixes: #26995
PR-URL: #29868
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this issue Nov 11, 2019
@dev-script @targos
doc: add options description for send APIs
98d31da 
Describes the meaning of the boolean return in process.send()
(doc/api/process.md) and worker.send() (doc/api/cluster.md) as
described in subprocess.send() (doc/api/child_process.md)

Fixes: #26995
PR-URL: #29868
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sam-github @shree-y @trivikr @dev-script @Drithyl