src: add missing "http_parser.h" include #12464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9d52222 the indirect "http_parser.h" include was removed, which made `NODE_STRINGIFY()` fail silently for the http parser version in `process.versions`. Ref: nodejs#12366 Fixes: nodejs#12463
addaleax
added
c++
nodejs-github-bot
added
the
c++
evanlucas
approved these changes
Apr 17, 2017
bnoordhuis
approved these changes
Apr 17, 2017
ghost
approved these changes
Apr 17, 2017
cjihrig
approved these changes
Apr 17, 2017
refack
approved these changes
Apr 17, 2017
|
LGTM |
aqrln
approved these changes
Apr 17, 2017
lpinca
approved these changes
Apr 17, 2017
jasnell
approved these changes
Apr 17, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2017
In 9d52222 the indirect "http_parser.h" include was removed, which made `NODE_STRINGIFY()` fail silently for the http parser version in `process.versions`. PR-URL: #12464 Fixes: #12463 Ref: #12366 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in 6a1275d |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9d52222 the indirect "http_parser.h"
include was removed, which made
NODE_STRINGIFY()fail silently for thehttp parser version in
process.versions.Ref: #12366
Fixes: #12463
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src/process.versions
CI: https://ci.nodejs.org/job/node-test-commit/9161/