Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process:Why http_parser version do not display? #12463

Closed
ghost opened this issue Apr 17, 2017 · 0 comments
Closed

process:Why http_parser version do not display? #12463

ghost opened this issue Apr 17, 2017 · 0 comments
Assignees
@addaleax
Labels
confirmed-bug Issues with confirmed bugs. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. process Issues and PRs related to the process subsystem.

Comments

@ghost
Copy link

ghost commented Apr 17, 2017 •
edited by ghost
Loading

  • Version:8.0.0-pre
  • Platform:Darwin Kernel Version 16.5.0: Fri Mar 3 16:52:33 PST 2017; root:xnu-3789.51.2~3/RELEASE_X86_64 x86_64
  • Subsystem:http_parser

When I type node -p process.versions.http_parser in Terminal,it display below:
HTTP_PARSER_VERSION_MAJOR.HTTP_PARSER_VERSION_MINOR.HTTP_PARSER_VERSION_PATCH

It is never happen in previous version,just nearest master branch.Windows and macOS be affected,and I do not test in Linux.
@addaleax addaleax added confirmed-bug Issues with confirmed bugs. process Issues and PRs related to the process subsystem. labels Apr 17, 2017
@ghost ghost changed the title Why http_parser version do not display? http_parser:Why http_parser version do not display? Apr 17, 2017
@addaleax addaleax added the http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. label Apr 17, 2017
@addaleax addaleax self-assigned this Apr 17, 2017
addaleax added a commit to addaleax/node that referenced this issue Apr 17, 2017
@addaleax
src: add missing "http_parser.h" include
269e144 
In 9d52222 the indirect "http_parser.h"
include was removed, which made `NODE_STRINGIFY()` fail silently for the
http parser version in `process.versions`.

Ref: nodejs#12366
Fixes: nodejs#12463
@addaleax addaleax mentioned this issue Apr 17, 2017
Closed
3 tasks
@ghost ghost changed the title http_parser:Why http_parser version do not display? process:Why http_parser version do not display? Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addaleax addaleax

Labels
confirmed-bug Issues with confirmed bugs. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: add missing "http_parser.h" include addaleax/node
1 participant
@addaleax