fix: Drop container error to warning #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asp8200
reviewed
Aug 14, 2023
asp8200
approved these changes
Aug 14, 2023
Codecov Report
@@ Coverage Diff @@
## dev #2396 +/- ##
==========================================
+ Coverage 71.12% 71.14% +0.02%
==========================================
Files 87 87
Lines 9408 9410 +2
==========================================
+ Hits 6691 6695 +4
+ Misses 2717 2715 -2
|
14 tasks
adamrtalbot
force-pushed
the
drop_docker_container_error_to_warn
branch
from
f2032c4
to
c224ba4
Compare
Changes: - Container registries do not have a consistent API, so calling them for container presence doesn't seem to work on GHCR or NVCR. - This drops the error to a warning so we don't fail tests. Relates to nf-core/modules#3693 and nf-core#2393
adamrtalbot
force-pushed
the
drop_docker_container_error_to_warn
branch
from
c224ba4
to
67a84e6
Compare
mashehu
approved these changes
Aug 15, 2023
|
You guys think this is OK? I wasn't sure if it was a good idea, but then again I don't see how to solve the container problem. |
|
yeah, it's a bit of cheating, but if it will not be too much to the point that we just start ignoring these warnings, it is fine. |
|
Okey dokey, then let's goooo. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
for container presence doesn't seem to work on GHCR or NVCR.
Relates to nf-core/modules#3693 and #2393
PR checklist
CHANGELOG.mdis updateddocsis updated