Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules linting any containers hosted on GHCR fails #2393

Closed
adamrtalbot opened this issue Aug 9, 2023 · 0 comments
Closed

Modules linting any containers hosted on GHCR fails #2393

adamrtalbot opened this issue Aug 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@adamrtalbot
Copy link
Contributor

Description of the bug

Any containers hosted on GHCR fails when linting. The error appears to be a 405 (method not allowed). It might affect other registries as well but it's not clear yet.

Command used and terminal output

nf-core --verbose modules lint fastk/fastk

System information

No response
@adamrtalbot adamrtalbot added the bug Something isn't working label Aug 9, 2023
adamrtalbot added a commit to adamrtalbot/tools that referenced this issue Aug 14, 2023
@adamrtalbot
fix: Drop container error to warning
4e7fd2f 
Changes:
 - Container registries do not have a consistent API, so calling them
   for container presence doesn't seem to work on GHCR or NVCR.
 - This drops the error to a warning so we don't fail tests.

Relates to nf-core/modules#3693 and nf-core#2393
@adamrtalbot adamrtalbot mentioned this issue Aug 14, 2023
Merged
4 tasks
adamrtalbot added a commit to adamrtalbot/tools that referenced this issue Aug 15, 2023
@adamrtalbot
fix: Drop container error to warning
99f508a 
Changes:
 - Container registries do not have a consistent API, so calling them
   for container presence doesn't seem to work on GHCR or NVCR.
 - This drops the error to a warning so we don't fail tests.

Relates to nf-core/modules#3693 and nf-core#2393
adamrtalbot added a commit to adamrtalbot/tools that referenced this issue Aug 15, 2023
@adamrtalbot
fix: Drop container error to warning
67a84e6 
Changes:
 - Container registries do not have a consistent API, so calling them
   for container presence doesn't seem to work on GHCR or NVCR.
 - This drops the error to a warning so we don't fail tests.

Relates to nf-core/modules#3693 and nf-core#2393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirpedrol @adamrtalbot