Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module linter does not detect TODO nf-core in test.yml #1271

Closed
grst opened this issue Sep 15, 2021 · 0 comments · Fixed by #1443
Closed

Module linter does not detect TODO nf-core in test.yml #1271

grst opened this issue Sep 15, 2021 · 0 comments · Fixed by #1443
Labels
bug Something isn't working linting
Milestone
2.3

Comments

@grst
Copy link
Member

grst commented Sep 15, 2021

Description of the bug

See nf-core/modules#697 (review), this should have been found by the linter and not by me
@grst grst added the bug Something isn't working label Sep 15, 2021
@ewels ewels added this to the 2.3 milestone Dec 9, 2021
@drpatelh drpatelh modified the milestones: 2.4, 2.3 Mar 8, 2022
ewels added a commit to ewels/nf-core-tools that referenced this issue Mar 14, 2022
@ewels
Linting checks test files for TODO statements as well as the main m…
c74a1c3 
…odule code

Closes nf-core#1271
@ewels ewels mentioned this issue Mar 14, 2022
Merged
4 tasks
@ewels ewels linked a pull request Mar 14, 2022 that will close this issue
Linting checks test files for TODO statements as well as the main module code #1443
Merged
4 tasks
@ewels ewels closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working linting
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Linting checks test files for TODO statements as well as the main module code ewels/nf-core-tools
3 participants
@ewels @grst @drpatelh