Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: snp-dists #697

Merged
merged 9 commits into from
Sep 15, 2021
Merged

module: snp-dists #697

merged 9 commits into from
Sep 15, 2021

Conversation

abhi18av
Copy link
Member

@abhi18av abhi18av commented Sep 8, 2021 •
edited
Loading

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@abhi18av abhi18av linked an issue Sep 8, 2021 that may be closed by this pull request
new module: snp-dists #696
Closed
@abhi18av abhi18av mentioned this pull request Sep 8, 2021
Closed
80 tasks
@abhi18av abhi18av self-assigned this Sep 13, 2021
@abhi18av abhi18av marked this pull request as ready for review September 13, 2021 19:06
@abhi18av abhi18av added new module Adding a new module Ready for Review labels Sep 13, 2021
@rpetit3
Copy link
Contributor

rpetit3 commented Sep 13, 2021

@abhi18av I'm good with it, but think one of the core members should probably make the final decision

@abhi18av abhi18av requested a review from a team September 14, 2021 06:41
@abhi18av
Copy link
Member Author

Yeah, makes sense. I've request the modules-team to review the PR now 🙏

grst
grst reviewed Sep 15, 2021
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just found a leftover TODO statement

tests/modules/snpdists/test.yml Outdated
Comment on lines 1 to 2
## TODO nf-core: Please run the following command to build this file:
# nf-core modules create-test-yml snpdists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover todo statement

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

Fixed with ac28108

Thanks for the review @grst !

@grst grst mentioned this pull request Sep 15, 2021
Closed
drpatelh
drpatelh reviewed Sep 15, 2021
View reviewed changes
modules/snpdists/main.nf Outdated Show resolved Hide resolved
drpatelh
drpatelh approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@drpatelh drpatelh merged commit 1bc3f6c into nf-core:master Sep 15, 2021
@abhi18av abhi18av deleted the abhinav/snp-dists branch September 15, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

@drpatelh drpatelh drpatelh approved these changes

@rpetit3 rpetit3 Awaiting requested review from rpetit3

Assignees

@abhi18av abhi18av

Labels
new module Adding a new module Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: snp-dists
4 participants
@abhi18av @rpetit3 @grst @drpatelh