Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First nf-core release & conversion to DSL2 #50

Merged
merged 121 commits into from
May 31, 2023
Merged

First nf-core release & conversion to DSL2 #50

merged 121 commits into from
May 31, 2023

Conversation

SusiJo
Copy link
Collaborator

@SusiJo SusiJo commented May 3, 2023

Many thanks to contributing to nf-core/bamtofastq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, add test data to testdata/
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md

@FriederikeHanssen FriederikeHanssen mentioned this pull request May 17, 2023
8 tasks
@FriederikeHanssen
Copy link
Contributor

@maxulysse @JoseEspinosa @sateeshperi you already approved the pseudo PR. Could you also approve this one, just to merge the dev changes now into master

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice 😃 ! Just dropped some small suggestions!

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
subworkflows/local/prepare_indices.nf Outdated Show resolved Hide resolved
subworkflows/local/prepare_indices.nf Outdated Show resolved Hide resolved
subworkflows/local/prepare_indices.nf Outdated Show resolved Hide resolved
testdata/First_SmallTest_Paired.bai Outdated Show resolved Hide resolved
workflows/bamtofastq.nf Outdated Show resolved Hide resolved
workflows/bamtofastq.nf Outdated Show resolved Hide resolved
workflows/bamtofastq.nf Show resolved Hide resolved
@SusiJo SusiJo requested a review from JoseEspinosa May 18, 2023 09:24
@SusiJo
Copy link
Collaborator Author

SusiJo commented May 18, 2023

Thanks @JoseEspinosa for the review. I added your suggestions in the new PR #58 .

SusiJo and others added 2 commits May 18, 2023 12:34
Apply formatting changes from code review
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SusiJo great job! 🚀

@SusiJo SusiJo requested a review from maxulysse May 19, 2023 12:44
Copy link

@ramprasadn ramprasadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM 🚀

@SusiJo SusiJo merged commit ceae4d6 into master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants