-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First nf-core release & conversion to DSL2 #50
Conversation
Co-authored-by: FriederikeHanssen <FriederikeHanssen@users.noreply.github.com>
Co-authored-by: FriederikeHanssen <FriederikeHanssen@users.noreply.github.com> Co-authored-by: Gisela Gabernet <gisela.gabernet@qbic.uni-tuebingen.de>
Co-authored-by: FriederikeHanssen <FriederikeHanssen@users.noreply.github.com>
Apply code review suggestions
Code review & formatting
Add Dependencies in changelog
Add new zenodo doi
@maxulysse @JoseEspinosa @sateeshperi you already approved the pseudo PR. Could you also approve this one, just to merge the dev changes now into master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice 😃 ! Just dropped some small suggestions!
Thanks @JoseEspinosa for the review. I added your suggestions in the new PR #58 . |
Apply formatting changes from code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SusiJo great job! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM 🚀
Many thanks to contributing to nf-core/bamtofastq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
testdata/
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md