Add legacy getter rector to set #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
feat/add-legacy-getter-rector-to-set
branch
from
7e72eb1
to
17e457e
Compare
😆 |
kesselb
approved these changes
Sep 18, 2024
|
@kesselb What’s your take on the OC ones? |
Talked around about that, consensus is let’s keep those in the set, it’s another question whether appilcations are using OC classes and whether we should add OCP interfaces for them. |
ChristophWurst
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generated that from lib/private/Server.php
I removed some which failed:
I don’t know about the ones which are from OC namespace, should we really expose them? They should only be used in server.
I had to use strings and not class names because otherwise the evil pre-commit hook wanted me to import all the classes.