Skip to content

Commit

Permalink
Merge pull request #15 from nextcloud-libraries/feat/add-legacy-gette…
Browse files Browse the repository at this point in the history 
…r-rector-to-set

Add legacy getter rector to set
  • Loading branch information
@come-nc
come-nc authored Sep 19, 2024
2 parents 41f383d + 17e457e commit 497149d
Show file tree
Hide file tree
Showing 4 changed files with 195 additions and 0 deletions.
186 changes: 186 additions & 0 deletions config/nextcloud-25/nextcloud-25-deprecations.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,197 @@

declare(strict_types=1);

use Nextcloud\Rector\Rector\LegacyGetterToOcpServerGetRector;
use Nextcloud\Rector\Rector\OcServerToOcpServerRector;
use Nextcloud\Rector\ValueObject\LegacyGetterToOcpServerGet;
use Rector\Config\RectorConfig;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->rules([
OcServerToOcpServerRector::class,
]);
$rectorConfig->ruleWithConfiguration(
LegacyGetterToOcpServerGetRector::class,
[
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCalendarManager', 'OCP\Calendar\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCalendarResourceBackendManager', 'OCP\Calendar\Resource\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCalendarRoomBackendManager', 'OCP\Calendar\Room\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getContactsManager', 'OCP\Contacts\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getEncryptionManager', 'OCP\Encryption\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getEncryptionFilesHelper', 'OCP\Encryption\IFile'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getEncryptionKeyStorage', 'OCP\Encryption\Keys\IStorage'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getRequest', 'OCP\IRequest'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getPreviewManager', 'OCP\IPreview'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getTagManager', 'OCP\ITagManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getSystemTagManager', 'OCP\SystemTag\ISystemTagManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getSystemTagObjectMapper', 'OCP\SystemTag\ISystemTagObjectMapper'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getAvatarManager', 'OCP\IAvatarManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getRootFolder', 'OCP\Files\IRootFolder'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getLazyRootFolder', 'OCP\Files\IRootFolder'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getUserManager', 'OCP\User\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getGroupManager', 'OCP\Group\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getUserSession', 'OCP\IUserSession'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getSession', 'OCP\ISession'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getTwoFactorAuthManager', 'OC\Authentication\TwoFactorAuth\Manager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getNavigationManager', 'OCP\INavigationManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getConfig', 'OCP\IConfig'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getSystemConfig', 'OC\SystemConfig'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getAppConfig', 'OCP\IAppConfig'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getURLGenerator', 'OCP\IURLGenerator'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getAppFetcher', 'OC\App\AppStore\Fetcher\AppFetcher'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getMemCacheFactory', 'OCP\ICacheFactory'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getGetRedisFactory', 'OC\RedisFactory'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getDatabaseConnection', 'OCP\IDBConnection'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getActivityManager', 'OCP\Activity\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getJobList', 'OCP\BackgroundJob\IJobList'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getLogFactory', 'OCP\Log\ILogFactory'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getRouter', 'OCP\Route\IRouter'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getSecureRandom', 'OCP\Security\ISecureRandom'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCrypto', 'OCP\Security\ICrypto'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getHasher', 'OCP\Security\IHasher'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCredentialsManager', 'OCP\Security\ICredentialsManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getHTTPClientService', 'OCP\Http\Client\IClientService'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getEventLogger', 'OCP\Diagnostics\IEventLogger'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getQueryLogger', 'OCP\Diagnostics\IQueryLogger'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getTempManager', 'OCP\ITempManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getAppManager', 'OCP\App\IAppManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getMailer', 'OCP\Mail\IMailer'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getDateTimeZone', 'OCP\IDateTimeZone'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getDateTimeFormatter', 'OCP\IDateTimeFormatter'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getMountProviderCollection', 'OCP\Files\Config\IMountProviderCollection'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getIniWrapper', 'bantu\IniGetWrapper\IniGetWrapper'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCommandBus', 'OCP\Command\IBus'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getTrustedDomainHelper', 'OCP\Security\ITrustedDomainHelper'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getLockingProvider', 'OCP\Lock\ILockingProvider'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getMountManager', 'OCP\Files\Mount\IMountManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getUserMountCache', 'OCP\Files\Config\IUserMountCache'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getMimeTypeDetector', 'OCP\Files\IMimeTypeDetector'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getMimeTypeLoader', 'OCP\Files\IMimeTypeLoader'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getNotificationManager', 'OCP\Notification\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCommentsManager', 'OCP\Comments\ICommentsManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getThemingDefaults', 'OCA\Theming\ThemingDefaults'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getIntegrityCodeChecker', 'OC\IntegrityCheck\Checker'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getSessionCryptoWrapper', 'OC\Session\CryptoWrapper'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCsrfTokenManager', 'OC\Security\CSRF\CsrfTokenManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getBruteForceThrottler', 'OCP\Security\Bruteforce\IThrottler'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet(
'getContentSecurityPolicyManager',
'OCP\Security\IContentSecurityPolicyManager',
),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet(
'getContentSecurityPolicyNonceManager',
'OC\Security\CSP\ContentSecurityPolicyNonceManager',
),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getStoragesBackendService', 'OCA\Files_External\Service\BackendService'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet(
'getGlobalStoragesService',
'OCA\Files_External\Service\GlobalStoragesService',
),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet(
'getUserGlobalStoragesService',
'OCA\Files_External\Service\UserGlobalStoragesService',
),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getUserStoragesService', 'OCA\Files_External\Service\UserStoragesService'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getShareManager', 'OCP\Share\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCollaboratorSearch', 'OCP\Collaboration\Collaborators\ISearch'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getAutoCompleteManager', 'OCP\Collaboration\AutoComplete\IManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getLDAPProvider', 'OCP\LDAP\ILDAPProvider'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getSettingsManager', 'OCP\Settings\IManager'),
// Deprecated since 20.0.0 Use 'get(\OCP\Files\AppData\IAppDataFactory')->get($app) instead
new LegacyGetterToOcpServerGet('getAppDataDir', 'OCP\Files\IAppData'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getLockdownManager', 'OCP\Lockdown\ILockdownManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCloudIdManager', 'OCP\Federation\ICloudIdManager'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getGlobalScaleConfig', 'OCP\GlobalScale\IConfig'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet(
'getCloudFederationProviderManager',
'OCP\Federation\ICloudFederationProviderManager',
),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getRemoteApiFactory', 'OCP\Remote\Api\IApiFactory'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getCloudFederationFactory', 'OCP\Federation\ICloudFederationFactory'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getRemoteInstanceFactory', 'OCP\Remote\IInstanceFactory'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getStorageFactory', 'OCP\Files\Storage\IStorageFactory'),
// Deprecated since 20.0.0
new LegacyGetterToOcpServerGet('getGeneratorHelper', 'OC\Preview\GeneratorHelper'),
],
);
};
2 changes: 2 additions & 0 deletions tests/Rector/LegacyGetterToOcpServerGetRector/Fixture/test_fixture.php.inc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class SomeClass
{
$request1 = OC::$server->getRequest();
$request2 = \OC::$server->getRequest();
$contactManager = \OC::$server->getContactsManager();
}
}

Expand All @@ -27,6 +28,7 @@ class SomeClass
{
$request1 = \OCP\Server::get(\OCP\IRequest::class);
$request2 = \OCP\Server::get(\OCP\IRequest::class);
$contactManager = \OCP\Server::get(\OCP\Contacts\IManager::class);
}
}

Expand Down
1 change: 1 addition & 0 deletions tests/Rector/LegacyGetterToOcpServerGetRector/config/config.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
[
/** @phpstan-ignore class.notFound */
new LegacyGetterToOcpServerGet('getRequest', IRequest::class),
new LegacyGetterToOcpServerGet('getContactsManager', 'OCP\Contacts\IManager'),
],
);
6 changes: 6 additions & 0 deletions tests/Set/Fixture/test_fixture.php.inc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ class SomeClass
$request2 = \OC::$server->get('\OCP\IRequest');
$request3 = OC::$server->get(IRequest::class);
script('mail', 'mail');
$request4 = OC::$server->getRequest();
$request5 = \OC::$server->getRequest();
$contactManager = \OC::$server->getContactsManager();
}
}

Expand All @@ -33,6 +36,9 @@ class SomeClass
$request2 = \OCP\Server::get('\OCP\IRequest');
$request3 = \OCP\Server::get(IRequest::class);
\OCP\Util::addScript('mail', 'mail', 'core');
$request4 = \OCP\Server::get(\OCP\IRequest::class);
$request5 = \OCP\Server::get(\OCP\IRequest::class);
$contactManager = \OCP\Server::get(\OCP\Contacts\IManager::class);
}
}

Expand Down

0 comments on commit 497149d

Please sign in to comment.