Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-ISSUE] Fixed issue with FetchingProvider remounting children #14

Merged
merged 1 commit into from
Sep 17, 2019
Merged

[NO-ISSUE] Fixed issue with FetchingProvider remounting children #14

merged 1 commit into from
Sep 17, 2019

Commits on Sep 17, 2019

  1. [NO-ISSUE] Fixed issue with FetchingProvider remounting children 

    * There was an issue with FetchingProvider that it rendered it's
children initially, before fetching was started, then rendering null and
finally rendering children again after fetching. This happened when
blocking was set to true (which is default). This was causing multiple
mounts of children, affecting performance.
* The issue was caused by misuse of "isFetching" flag in rendering logic
since it was initially false, before fetching has even started.
* Replacing "isFetching" with "isFetched" is restoring original purpose
of "blocking" flag, since rendering should or shouldn't be blocked until
data is fetched, not while it is fetching as it was implemented so far.
    Ivan Cosic authored and Ivan Cosic committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    9bcb80f View commit details
    Browse the repository at this point in the history