[NO-ISSUE] Fixed issue with FetchingProvider remounting children #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There was an issue with FetchingProvider that it rendered it's children initially, before fetching was started, then rendering null and finally rendering children again after fetching. This happened when blocking was set to true (which is default). This was causing multiple mounts of children, affecting performance. * The issue was caused by misuse of "isFetching" flag in rendering logic since it was initially false, before fetching has even started. * Replacing "isFetching" with "isFetched" is restoring original purpose of "blocking" flag, since rendering should or shouldn't be blocked until data is fetched, not while it is fetching as it was implemented so far.
oliverlaz
approved these changes
Sep 17, 2019
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
children initially, before fetching was started, then rendering null and
finally rendering children again after fetching. This happened when
blocking was set to true (which is default). This was causing multiple
mounts of children, affecting performance.
since it was initially false, before fetching has even started.
of "blocking" flag, since rendering should or shouldn't be blocked until
data is fetched, not while it is fetching as it was implemented so far.