Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external: fix class references #530

Merged
merged 1 commit into from
Oct 12, 2023
Merged

external: fix class references #530

merged 1 commit into from
Oct 12, 2023

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Oct 9, 2023

Fixes #527

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Oct 9, 2023
@jrchamp jrchamp requested a review from a team October 9, 2023 18:33
@jrchamp jrchamp self-assigned this Oct 9, 2023
smbader
smbader approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find from the larger test suite.
Thank you @jrchamp for the fix.

@jrchamp jrchamp merged commit 1b5383f into ncstate-delta:main Oct 12, 2023
6 checks passed
@jrchamp jrchamp deleted the fix/mod_zoom-external branch October 12, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbader smbader smbader approved these changes

Assignees

@jrchamp jrchamp

Labels
bug Fixes problems or reduces technical debt
Projects
Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid calls to mod_zoom_external
2 participants
@jrchamp @smbader