Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid calls to mod_zoom_external #527

Closed
danmarsden opened this issue Oct 2, 2023 · 2 comments · Fixed by #530
Closed

invalid calls to mod_zoom_external #527

danmarsden opened this issue Oct 2, 2023 · 2 comments · Fixed by #530
Assignees
Labels
bug Fixes problems or reduces technical debt

Comments

@danmarsden
Copy link
Contributor

c522487 renamed mod_zoom_external to mod_zoom\external

but... events.php still refers to mod_zoom_external, and so does classes/output/mobile.php

@danmarsden
Copy link
Contributor Author

this triggers the following unit test failures:

There were 2 errors:

  1. core\externallib_test::test_all_external_info with data set "mod_zoom_get_state" (stdClass Object (...))
    coding_exception: Coding error detected, it must be fixed by a programmer: Cannot find external class mod_zoom_external

/var/www/html/lib/externallib.php:93
/var/www/html/lib/tests/externallib_test.php:442
/var/www/html/lib/phpunit/classes/advanced_testcase.php:80
phpvfscomposer:///var/www/html/vendor/phpunit/phpunit/phpunit:97

  1. core\externallib_test::test_all_external_info with data set "mod_zoom_grade_item_update" (stdClass Object (...))
    coding_exception: Coding error detected, it must be fixed by a programmer: Cannot find external class mod_zoom_external

/var/www/html/lib/externallib.php:93
/var/www/html/lib/tests/externallib_test.php:442
/var/www/html/lib/phpunit/classes/advanced_testcase.php:80
phpvfscomposer:///var/www/html/vendor/phpunit/phpunit/phpunit:97

@smbader smbader added the bug Fixes problems or reduces technical debt label Oct 5, 2023
@smbader smbader self-assigned this Oct 5, 2023
@jrchamp
Copy link
Collaborator

jrchamp commented Oct 9, 2023

Thanks @danmarsden! Really glad you caught this before we released and tagged a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants