Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Add area-step-range chart type #3776

Closed
wants to merge 3 commits into from

Conversation

vlaforet
Copy link
Contributor

@vlaforet vlaforet commented May 21, 2024

Details

This PR adds the area-step-range chart type. This new type is part of the AreaRange and Step categories which makes a stepped range.
No new code needed to be added apart from adding the type and its categories.

@netil
Copy link
Member

netil commented May 23, 2024

Hi @vlaforet, thanks for the contribution!
I'll review soon.

@coveralls
Copy link

coveralls commented May 23, 2024

Coverage Status

coverage: 93.726% (-0.005%) from 93.731%
when pulling b96566f on vlaforet:master
into 02987ab on naver:master.

@vlaforet
Copy link
Contributor Author

Fixed a bug that prevented onClick on area-step-range charts.
Onclick calls isWithinShape which calls isWithinStep with the return value of the scale function. The scale function expects the point value as parameter. This value is a number for "step" charts but it is an array of mid, low, high in "area-step-range".
I changed the call to the scale function to take the base value of the point (returned by getBaseValue(d)).

@netil
Copy link
Member

netil commented Jun 13, 2024

@vlaforet mostly nice implementing to use current existing condition without adding extra code.
Could you add test code?

@vlaforet
Copy link
Contributor Author

Thanks!
Yes sure. I will work on tests this week.

@netil netil closed this in 03b9a7d Jun 25, 2024
@netil
Copy link
Member

netil commented Jun 25, 2024

@vlaforet added test codes and demos.
Thanks again for the contribution!

@vlaforet
Copy link
Contributor Author

vlaforet commented Jun 25, 2024

Nice, thank you!
I had not been able to get to it yet.

@netil netil added the feature label Jun 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
# [3.13.0-next.1](3.12.4...3.13.0-next.1) (2024-07-25)

### Bug Fixes

* **api:** Fix to return indexed categories ([55c17c6](55c17c6)), closes [#3365](#3365)
* **bar:** Fix stacking bar position on multiple xs ([216da62](216da62)), closes [#3372](#3372)
* **candlestick:** Fix rendering on rotated axis ([17f5058](17f5058)), closes [#3387](#3387)
* **clip:** Fix x axis hide on title.bottom ([beec1bb](beec1bb)), closes [#3364](#3364)
* **option:** Fix inconsistency of padding ([0c1ce81](0c1ce81)), closes [#3426](#3426)
* **regions:** Mitigate broken dashed lines rendering ([d1df575](d1df575)), closes [#3790](#3790)
* **shape:** Fix circleY() undefined error ([f4ac3f1](f4ac3f1)), closes [#3388](#3388)
* **subchart, zoom:** Fix returning domain value ([90338ec](90338ec)), closes [#3347](#3347)
* **subchart:** Fix handlebar position ([b897cbb](b897cbb)), closes [#3358](#3358)
* **title:** fix title text center align ([b254a61](b254a61)), closes [#3363](#3363)
* **tooltip:** Fix tooltip.format.value call ([f7d587d](f7d587d)), closes [#3371](#3371)
* **tooltip:** Fix tootip display on tooltip.init ([98e6f8b](98e6f8b)), closes [#3369](#3369)

### Features

* **api:** Intent to ship subchart method ([976f04a](976f04a)), closes [#3342](#3342)
* **bar:** Enhance bar width to adjust from callback ([4ce74fc](4ce74fc)), closes [#3820](#3820)
* **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202)
* **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873)
* **regions:** Enhance regions rendering ([567b323](567b323)), closes [#3830](#3830) [#3790](#3790)
* **regions:** Intent to ship regions.label ([b4e3bc2](b4e3bc2)), closes [#3319](#3319)
* **shape:** Intent to ship area-step-range type ([03b9a7d](03b9a7d)), closes [#3776](#3776)
* **types:** Add area-step-range chart type ([2a763d2](2a763d2))
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
# [3.13.0](3.12.4...3.13.0) (2024-08-23)

### Bug Fixes

* **regions:** Mitigate broken dashed lines rendering ([d1df575](d1df575)), closes [#3790](#3790)
* **zoom:** Fix zoom wheel interaction ([81ea359](81ea359)), closes [#3856](#3856)

### Features

* **bar:** Enhance bar width to adjust from callback ([4ce74fc](4ce74fc)), closes [#3820](#3820)
* **legend:** Provide original data id in format callback ([5ce41c7](5ce41c7)), closes [#3663](#3663)
* **regions:** Enhance regions rendering ([567b323](567b323)), closes [#3830](#3830) [#3790](#3790)
* **shape:** Intent to ship area-step-range type ([03b9a7d](03b9a7d)), closes [#3776](#3776)
* **types:** Add area-step-range chart type ([2a763d2](2a763d2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants