Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheel event zoom don't work on Safari #3856

Closed
netil opened this issue Jul 26, 2024 · 1 comment
Closed

Wheel event zoom don't work on Safari #3856

netil opened this issue Jul 26, 2024 · 1 comment
Assignees
@netil
Labels
bug

Comments

@netil
Copy link
Member

netil commented Jul 26, 2024

Steps to check or reproduce
@netil netil added the bug label Jul 26, 2024
@netil netil self-assigned this Jul 26, 2024
@netil
Copy link
Member Author

netil commented Jul 26, 2024

As of the side-effect #3800

This is because we don't build event regions inside SVG content.

It needs bind wheel event to svg element prior to bind other events and need to be applied only safari.

@netil netil mentioned this issue Jul 26, 2024
Closed
netil pushed a commit to netil/billboard.js that referenced this issue Jul 26, 2024
fix(zoom): Fix zoom wheel interaction
94b6718 
As of Safari needs bind wheel event to svg element, prior within element,
apply workaround to Safari desktop only

Ref naver#3856
@netil netil mentioned this issue Jul 26, 2024
Merged
@netil netil closed this as completed in 81ea359 Jul 26, 2024
github-actions bot pushed a commit that referenced this issue Aug 13, 2024
@semantic-release-bot
chore(release): 3.13.0-next.2 [skip ci]
b37bdb1 
# [3.13.0-next.2](3.13.0-next.1...3.13.0-next.2) (2024-08-13)

### Bug Fixes

* **zoom:** Fix zoom wheel interaction ([81ea359](81ea359)), closes [#3856](#3856)

### Features

* **legend:** Provide original data id in format callback ([5ce41c7](5ce41c7)), closes [#3663](#3663)
github-actions bot pushed a commit that referenced this issue Aug 23, 2024
@semantic-release-bot
chore(release): 3.13.0 [skip ci]
6a6c88d 
# [3.13.0](3.12.4...3.13.0) (2024-08-23)

### Bug Fixes

* **regions:** Mitigate broken dashed lines rendering ([d1df575](d1df575)), closes [#3790](#3790)
* **zoom:** Fix zoom wheel interaction ([81ea359](81ea359)), closes [#3856](#3856)

### Features

* **bar:** Enhance bar width to adjust from callback ([4ce74fc](4ce74fc)), closes [#3820](#3820)
* **legend:** Provide original data id in format callback ([5ce41c7](5ce41c7)), closes [#3663](#3663)
* **regions:** Enhance regions rendering ([567b323](567b323)), closes [#3830](#3830) [#3790](#3790)
* **shape:** Intent to ship area-step-range type ([03b9a7d](03b9a7d)), closes [#3776](#3776)
* **types:** Add area-step-range chart type ([2a763d2](2a763d2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@netil