Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump snowflake-sdk to 1.6.0 #8

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

koszti
Copy link
Contributor

@koszti koszti commented Mar 6, 2021

This PR is to bump snowflake-sdk to 1.6.0.

1.6.0 comes with new authenticator methods and supports External Browser SSO, Key Pair and OAuth to connect to snowflake.

Can you please bump the snowflake-sdk version and release a new package to npm? This package is great, used in sqltools-snowflake-driver and the bump would allow the SQL client to use further authentication methods to snowflake.

@natesilva
Copy link
Owner

natesilva commented Mar 8, 2021

Is there anything else we need to do to support the new features? I don’t see any additional options documented on https://docs.snowflake.com/en/user-guide/nodejs-driver-use.html#additional-connection-options.

The concern would be for TypeScript users, since we have a defined ConnectionOptions type. If there are additional undocumented options you could still use them but you’d have to cast your connection options object that you pass to our constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants