Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externalbrowser authenticator for SSO #13

Closed
bharathjs93 opened this issue Feb 16, 2021 · 7 comments
Closed

externalbrowser authenticator for SSO #13

bharathjs93 opened this issue Feb 16, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@bharathjs93
Copy link

Hello,
I'd like to know any plans about implementing external browser authenticator for SSO.

@koszti
Copy link
Collaborator

koszti commented Feb 16, 2021

There are plans adding it, but it highly depends on when the externalbrowser authentication feature will be available in the upstream snowflake-nodejs-connector driver.

Good news is that last week this PR added external browser authentication to the nodejs connector. We need to wait until snowflake officially releasing the new driver but at the same time we can start testing and developing it.

@koszti koszti added the enhancement New feature or request label Feb 16, 2021
@yapnel
Copy link

yapnel commented Feb 18, 2021

I am also awaiting for this feature too

@koszti
Copy link
Collaborator

koszti commented Feb 21, 2021

I created a new auth-externalbrowser-sso branch and added this commit to test the unreleased SSO authenticator feature of the upstream snowflake nodejs connector. The branch modifies the connection form and implements the EXTERNALBROWSER authentication method. Unfortunately I receive this error:

390133: SAML response is invalid or matching user is not found. Contact your local system administrator.

My snowflake instance is using OKTA, I'm sure it's configured and working fine with other snowflake clients.

This might be a bug in the the SSO feature of the upstream nodejs driver. It's also possible that it working well with many Identity Providers but it doesn't like OKTA. I think we need to wait until SSO support will be documented and released officially by Snowflake.

Repo: https://github.com/snowflakedb/snowflake-connector-nodejs
Documentation: https://docs.snowflake.com/en/user-guide/nodejs-driver-use.html

@yapnel
Copy link

yapnel commented Mar 3, 2021

Hi the latest 1.6 version is out. No info of what is released. Are you able to test it please? @koszti

@koszti
Copy link
Collaborator

koszti commented Mar 6, 2021

Thanks, it's promising and I started working on it. It requires to bump the snowflake-sdk in the upstream snowflake-promise package first. I sent PR at natesilva/snowflake-promise#8 and hopefully will get merged very soon.

@koszti
Copy link
Collaborator

koszti commented Mar 12, 2021

tested locally and browser based SSO is working with the latest snowflake sdk package. To support it properly in the SQL client we need to make another a small change in the snowflake-promise package. PR sent to natesilva/snowflake-promise#9.

@koszti
Copy link
Collaborator

koszti commented Mar 13, 2021

New version with browser based SSO auth (0.4.0) is published to VSCode Marketplace and it's ready to upgrade.

@koszti koszti closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants