Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values for stuct members and scalar initialization of array members #795

Merged
merged 40 commits into from
Jul 2, 2021

Conversation

rohandkn
Copy link
Contributor

Originating Project/Creator F Prime
Affected Component Autocoder
Affected Architectures(s) serializable
Related Issue(s)
Has Unit Tests (y/n) Y
Builds Without Errors (y/n) Y
Unit Tests Pass (y/n) Y
Documentation Included (y/n) Y

Change Description

Added support to allow a nested default element for struct members in F' XML. Autocoder initializes struct member to this
value in the constructor for the serializable. Also, allowed for initialization of arrays with a scalar value. This sets all elements in the array to the scalar value.

Rationale

These changes to the autocoder were made to support the FPP syntax and features.

Testing/Review Recommendations

Created new serialize4 test which tests autocoder functionality as it pertains to serializable objects.

All tests built and run with no issues.

Future Work

N/A

Fetch upstream F' into serial default changes
@LeStarch LeStarch requested a review from bocchino June 30, 2021 16:02
@LeStarch
Copy link
Collaborator

@bocchino want to review this too?

Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request, otherwise looks good!

docs/UsersGuide/dev/xml-specification.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LeStarch LeStarch merged commit 5dcbb5c into nasa:devel Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants