Fetch upstream F' into serial default changes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our XML files had incorrect schema paths, so they needed to be corrected or removed. Because of the upcoming transition to F'' YAML modeling, removing the schema refrences is an easier approach than correcting all component xml files.
…cessary for reading data out of certain devicesm, mainly memory chips, but also for an ADC we need to read data from * lestarch: adding missspelling * lestarch: cleaning out schema line that we've discontinued. Co-authored-by: Brandon Metz <bcmetz@jpl.nasa.gov>
* Added support for default attributes in discrete enum declaration in XML * Added tests and fixed header file include in hpp file * Added enum fixes to cpp template, changed default documentation, and tested XmlEnumParser.py * Added enum fixes to cpp template, changed default documentation, and tested XmlEnumParser.py * Added test for uninitialized value for not-set default values * Added nothing * Removed changes from gitignore * Added default value tests for enum * Added minor changes to improve readability of enum default value initialization * Merged changes from upstream f prime * Resolved Enum XML merge conflict * Resolved Enum XML merge conflict * Added change to enum default value test * Removed unneeded files
rohandkn
pushed a commit
that referenced
this pull request
Jul 21, 2021
* Create tutorial-support.yml * Update tutorial-support.yml GpsApp tutorial to be pulled for build test and submodules to be pulled recursively * Implementation of tutorial workflow * typo in repo address * Added missing github action file * Changed workflow path * Changed dir paths * Work around for workflow * work around * troubleshooting * troubleshoot * troubleshoot * Performance update * Path correction * troubleshoot * Dockerfile correction * path change * path change * path fix * path fix * path fix * path fix * paht fix * Revert to changes * Completed workflow for tutorial support * troubleshoot * Build path error * Optimization of workflow * Path fix * Path fix * Path fix #1 * path fix #2 * path check * Workflow test * Workflow test #2 * Added logging feature * Logs Troubleshoot * Typo fix * Troubleshoot #1 * Troubleshoot #2 * Corrected typo on path * Troubleshoot #3 * Troubleshoot #4 * Troubleshoot #5 * Removed log archive feature * Changed repo path to conform pull request merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
A description of the changes contained in the PR.
Rationale
A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.
Testing/Review Recommendations
Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.
Future Work
Note any additional work that will be done relating to this issue.