Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code gen for command overflow hooks #497

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

bocchino
Copy link
Collaborator

@bocchino bocchino commented Aug 22, 2024

  • In the function prototypes and at the call sites, follow the pattern of the pre-message hooks. Don't include the command arguments. At the call sites, these are in serialized form and so are not available in typed argument form.
  • Re-enable the call sites, which were commented out to get the code to compile.
  • Update the unit tests.
  • Update the version stamp to after v2.1.0.
  • Re-generate the docs.

Closes #496.

@LeStarch
Copy link
Collaborator

@bocchino once merged, ready for a alpha?

@bocchino
Copy link
Collaborator Author

Yes, I will merge it and then make an alpha release.

@bocchino bocchino merged commit ea0cfcd into main Aug 22, 2024
11 checks passed
@bocchino bocchino deleted the issue-496-command-hooks branch August 22, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code generation for command overflow hooks
3 participants