Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code generation for command overflow hooks #496

Closed
bocchino opened this issue Aug 16, 2024 · 1 comment · Fixed by #497
Closed

Fix code generation for command overflow hooks #496

bocchino opened this issue Aug 16, 2024 · 1 comment · Fixed by #497
Assignees
Labels
code generation Issues related to code generation
Milestone

Comments

@bocchino
Copy link
Collaborator

bocchino commented Aug 16, 2024

To call the hooks in the way they are currently designed, we will need to deserialize the command arguments before calling the hook. See #495. This will require some refactoring of the code gen, as we will need to do the same thing as in the code that calls the command handlers.

Alternatively, we could do what the command pre-message hooks currently do, and just pass the opcode and command sequence number, without the arguments.

This issue is blocked on #493 to avoid conflicts.

@bocchino bocchino added code generation Issues related to code generation blocked Issue is blocked pending resolution of another issue and removed blocked Issue is blocked pending resolution of another issue labels Aug 16, 2024
@bocchino
Copy link
Collaborator Author

Unblocking this issue. We'll do it the simple way, which shouldn't cause undue conflicts.

@bocchino bocchino self-assigned this Aug 21, 2024
@bocchino bocchino added this to the v2.1.1 milestone Aug 21, 2024
bocchino added a commit that referenced this issue Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code generation Issues related to code generation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant