-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update native projects #6
Conversation
@@ -41,7 +41,7 @@ | |||
"axios": "^0.18.0", | |||
"computed-async-mobx": "^4.1.0", | |||
"expo": "^27.0.1", | |||
"mobx": "^5.1.2", | |||
"mobx": "^4.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decide to downgrade mobx instead of upgrading javascriptcore in android native project as it require bumping min sdk version
have you tried this? |
@shroomist saw it as an option but didn't want to mess with android native dependency and |
recently I've came across this one seems like it's some default value, that's been left behind, not updated at react-native project. @donce might also have an opinion here |
sdk 21 is Android 5.0 (LOLLIPOP) and according to this usage bellow that is ~18% while usage bellow sdk 16 is ~2% ¯\(ツ)/¯ |
in that case we're dropping support for jellybean up to lollipop, which are no longer maintained and together <8% of devices as of february 2018. |
Since this fixed master builds for android, I fully approve it :) We can decide later whether we need new features for MobX or not - we're not using them ATM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be eager to bump the sdk versions later on ;D
Retry of #5, had a number of issues doing this:
react-native-git-upgrade
would fail solving conflicts and abortManaged to successfully launch on ios and android.