Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update react native projects #5

Closed
wants to merge 2 commits into from
Closed

Conversation

Arrnas
Copy link
Contributor

@Arrnas Arrnas commented Sep 26, 2018

Why this is needed => ios project didn't work on xcode because reason
What I did => ran react-native-git-upgrade and fixed conflicts.

@donce @shroomist

"presets": ["babel-preset-expo"],
"env": {
"development": {
"plugins": ["transform-react-jsx-source"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some issues with the javascript side of the project, removed this following this suggestion, maybe an update was needed instead but I assume this won't be relevant after switch to typescript.

"plugins": ["transform-react-jsx-source"]
}
}
"presets": ["module:metro-react-native-babel-preset"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might not be needed, seems to also work with babel-preset-expo

@@ -1,5 +1,5 @@
{
"name": "MysterionReact",
"name": "MysteriumVPN",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating native projects would fail because it would look for project with the legacy name instead of the correct one.

@donce
Copy link
Contributor

donce commented Sep 27, 2018

It's hard to review it without react-native experience.. Does it work on android as well?

@Arrnas Arrnas closed this Sep 28, 2018
@Arrnas Arrnas deleted the feature/update_react_native branch September 28, 2018 06:08
@Arrnas Arrnas mentioned this pull request Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants