Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slider][docs] Polish Music player demo #43748

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 13, 2024

A quick polish on #43743. I thought this would look better and be denser, using less vertical space:

Before
SCR-20240913-rjpk

After
SCR-20240913-rjmt

This docs option is not used so often on Material UI. We use it a lot with the MUI X Data Grid though, e.g. https://mui.com/x/react-data-grid/#mit-license-free-forever

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: slider This is the name of the generic UI component, not the React module! labels Sep 13, 2024
@mui-bot
Copy link

mui-bot commented Sep 13, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6acf57f

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! TIL about bg: inline.

I'll take a look and see if we can get rid of the top margin of the bottom bar when bg: inline is present, but maybe other demos need it, not sure.

Screenshot 2024-09-14 at 20 35 30

Also, it'd be nice that the demo follows the border radius of the container:

Screenshot 2024-09-14 at 20 33 59

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 14, 2024

maybe other demos need it, not sure.

For the data grid demos linked in the PR description, I doubt it would work without 😁

@oliviertassinari oliviertassinari merged commit 7723197 into mui:master Sep 15, 2024
24 checks passed
@oliviertassinari oliviertassinari deleted the slider-docs-polish branch September 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants