Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Remove position:relative from regression container #43743

Merged

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Sep 13, 2024

@mui-bot
Copy link

mui-bot commented Sep 13, 2024

Netlify deploy preview

https://deploy-preview-43743--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f3748bd

@aarongarciah aarongarciah marked this pull request as ready for review September 13, 2024 11:40
@Janpot
Copy link
Member

Janpot commented Sep 13, 2024

flakyness of https://app.argos-ci.com/mui/material-ui/builds/32056/108822015 is not solved 😢

@aarongarciah
Copy link
Member Author

The argos changes seem unrelated:

The first one is caused by the removal of position:relative.

@aarongarciah
Copy link
Member Author

aarongarciah commented Sep 13, 2024

@Janpot I updated the MusicPlayerSlider demo to be self-contained. Now:

  • It doesn't depend on some parent element setting position:relative.
  • It includes the necessary padding to make it look good.

before: the gradient background covers all of the demo surface, including the demo container padding. It overflows the rounded corners of the demo container.

Screenshot 2024-09-13 at 14 09 19

after: the demo is self contained, doesn't overflow the demo container. Not as beautiful as before. Ideally we should have a way of removing padding in specific demos.

Screenshot 2024-09-13 at 14 18 21

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@aarongarciah aarongarciah merged commit bede032 into mui:master Sep 13, 2024
22 checks passed
@oliviertassinari oliviertassinari added the scope: code-infra Specific to the core-infra product label Sep 13, 2024
@oliviertassinari
Copy link
Member

flakyness of https://app.argos-ci.com/mui/material-ui/builds/32056/108822015 is not solved 😢

@Janpot But we have a cleaner screenshot environment at least 😄. Issue created to propagate it: mui/mui-public#199

I updated the MusicPlayerSlider demo to be self-contained.

@aarongarciah Nice, I tried #43748 to push it a step further.

@aarongarciah aarongarciah deleted the remove-position-relative-regression-test branch September 14, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants