-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Grid] Update Grid props to match PigmentGrid #42742
Conversation
78911f1
to
a416448
Compare
35b31ba
to
1eae06c
Compare
1eae06c
to
ebf69d2
Compare
@danilo-leal may I ask you to review the marketing pages updates? To check everything is still working as expected 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This is awesome, well done @DiegoAndai.
One comment from me is the Argos. I think the demos should not change so that it verifies the implementation change. To me, it's fine to show xs=8
instead of size=8
etc.
23dfe2b
to
5e5e358
Compare
09603dd
to
7b2bb15
Compare
7b2bb15
to
b3b22f7
Compare
This reverts commit b3b22f7.
I pushed a temporary commit (b3b22f7) so that it runs the Argos tests and verifies the implementation, and the test succeeded: https://app.argos-ci.com/mui/material-ui/builds/29397/96799521
I think the updated labels match better with the new API, though, so after the successful test, I reverted the changes back (186c18e) This way, we have the improved demos, and we verified with Argos, best of both worlds 😉 Also, I had to do some minor refactoring (f5b6746) after #42693 was merged. In case you want to review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I don't see anything immediatelly broken 👍
Summary
This PR updates the Grid v2 API to match the upcoming Pigment Grid, so they are interchangeable.
Changes
Argos failures
The Argos failures are expected as the docs demos labels changes, but please review them as well to check if there's anything you wouldn't expect.
Not covered
We should discuss if we should stabilize the Grid, but the scope of this PR is already big so I don't want to cover these here. I created an issue for this: