Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mui-system][material-ui][Grid v2] Stabilize API #42761

Closed
DiegoAndai opened this issue Jun 26, 2024 · 6 comments · Fixed by #43054
Closed

[mui-system][material-ui][Grid v2] Stabilize API #42761

DiegoAndai opened this issue Jun 26, 2024 · 6 comments · Fixed by #43054
Assignees
Labels
component: Grid The React component. package: material-ui Specific to @mui/material package: system Specific to @mui/system

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Jun 26, 2024

What's the problem?

The Grid v2 component is marked as unstable. With the addition of the Pigment Grid, a stable no-runtime alternative with the same API, we should mark the Grid v2 as stable.

Also, with three separate grid components, I worry it might get confusing to know which one to choose for users

Solution

Stabilize Grid v2 and deprecate Grid, making Grid v2 the option for runtime Grid.

Search keywords: gridv2 unstable grid

@DiegoAndai DiegoAndai added component: Grid The React component. RFC Request For Comments labels Jun 26, 2024
@DiegoAndai DiegoAndai self-assigned this Jun 26, 2024
@DiegoAndai DiegoAndai added the on hold There is a blocker, we need to wait label Jun 26, 2024
@DiegoAndai
Copy link
Member Author

On hold: #42742

@stunaz
Copy link
Contributor

stunaz commented Jun 26, 2024

hmm I saw component being built in pigment-css, which I didn't expect.
I thought those component will be part of base-ui, and that material-ui & joy-ui will use them or reexport them if needed.

@siriwatknp
Copy link
Member

siriwatknp commented Jun 27, 2024

I prefer making Grid v2 stable in v6 (without renaming the name) and deprecating the Grid v1.

I think it's the right time to get rid of the Grid v1 because the v2 is using gap by default thanks to @DiegoAndai. It's much better and I think the community will like it.

For the docs, I think we can swap so /material-ui/react-grid presents the new Grid and /material-ui/react-deprecated-grid presents Grid v1.

@DiegoAndai
Copy link
Member Author

I prefer making Grid v2 stable in v6 (without renaming the name) and deprecating the Grid v1.

For the docs, I think we can swap so /material-ui/react-grid presents the new Grid and /material-ui/react-deprecated-grid presents Grid v1.

I agree, this approach makes sense 👍🏼

@DiegoAndai DiegoAndai added this to the Material UI: v6 milestone Jul 8, 2024
@DiegoAndai DiegoAndai changed the title [RFC][Grid v2] Stabilize API [Grid v2] Stabilize API Jul 18, 2024
@DiegoAndai DiegoAndai added package: system Specific to @mui/system package: material-ui Specific to @mui/material and removed RFC Request For Comments on hold There is a blocker, we need to wait labels Jul 18, 2024
@DiegoAndai DiegoAndai changed the title [Grid v2] Stabilize API [mui-system][material-ui][Grid v2] Stabilize API Jul 18, 2024
@oliviertassinari
Copy link
Member

Is #42000 about the same issue?

@siriwatknp
Copy link
Member

Is #42000 about the same issue?

Yes, I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. package: material-ui Specific to @mui/material package: system Specific to @mui/system
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants