Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Update MUI X deps and migrate TreeView demos to v7 API #42149

Merged
merged 9 commits into from
May 9, 2024
Merged

[website] Update MUI X deps and migrate TreeView demos to v7 API #42149

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f5c1fa6
wip
noraleonte May 6, 2024
7602360
update treeview demos
noraleonte May 6, 2024
97e4414
Apply suggestions from code review - Danilo & Lukas
noraleonte May 7, 2024
c9e72a3
tidy up horizontal spacing
noraleonte May 7, 2024
acc240b
tidy up demo spacing
noraleonte May 7, 2024
4ec5797
fix linting
noraleonte May 7, 2024
f0b6996
date range demo
noraleonte May 7, 2024
8d8010e
Merge branch 'next' of github.com:noraleonte/material-ui into update-…
noraleonte May 9, 2024
fc694e6
add x-license
noraleonte May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@
"@mui/system": "workspace:^",
"@mui/types": "workspace:^",
"@mui/utils": "workspace:^",
"@mui/x-charts": "6.19.8",
"@mui/x-charts": "7.3.2",
"@mui/x-data-grid": "7.3.1",
"@mui/x-data-grid-generator": "7.3.1",
"@mui/x-data-grid-premium": "7.3.1",
"@mui/x-data-grid-pro": "7.3.1",
"@mui/x-date-pickers": "6.19.9",
"@mui/x-date-pickers-pro": "6.19.9",
"@mui/x-date-pickers": "7.3.2",
"@mui/x-date-pickers-pro": "7.3.2",
"@mui/x-license-pro": "6.10.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing it.
The package does not seem to be used anywhere explicitly and has already been renamed to @mui/x-license.
It is a direct dependency of the paid packages and if there are no direct references to it in the project, I don't see a reason to have it explicitly listed. 🙈

Suggested change
"@mui/x-license-pro": "6.10.2",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have

import { LicenseInfo } from '@mui/x-data-grid-pro';

Which IMHO is a bad pattern now that we use the license key for several X commercial packages
I would prefer to install @mui/x-license and set the license from it instead of setting from the grid (which is deprecated in #11956)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point. 👌
However, IMHO, this could also be a separate PR as well, because it does not seem directly related to what is being done here. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, but removing the package is not related to this PR either 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-requesting reviews just to make sure I didn't mess something up 🙈

"@mui/x-tree-view": "6.17.0",
"@mui/x-tree-view": "7.3.1",
"@popperjs/core": "^2.11.8",
"@react-spring/web": "^9.7.3",
"autoprefixer": "^10.4.19",
Expand Down
Loading
Loading