-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Update MUI X deps and migrate TreeView demos to v7 API #42149
Conversation
Netlify deploy previewhttps://deploy-preview-42149--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Dropping in just a few very visual tweaks 😬 One quick remark that stood out to me, though: these updated instances look way more spaced out than the previous iteration. I'd potentially tighten up a bit more. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a few nitpicks, but I didn't go in depth in the Tree View changes. 🙈
docs/package.json
Outdated
"@mui/x-date-pickers": "6.19.9", | ||
"@mui/x-date-pickers-pro": "6.19.9", | ||
"@mui/x-date-pickers": "7.3.2", | ||
"@mui/x-date-pickers-pro": "7.3.2", | ||
"@mui/x-license-pro": "6.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing it.
The package does not seem to be used anywhere explicitly and has already been renamed to @mui/x-license
.
It is a direct dependency of the paid packages and if there are no direct references to it in the project, I don't see a reason to have it explicitly listed. 🙈
"@mui/x-license-pro": "6.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have
import { LicenseInfo } from '@mui/x-data-grid-pro';
Which IMHO is a bad pattern now that we use the license key for several X commercial packages
I would prefer to install @mui/x-license
and set the license from it instead of setting from the grid (which is deprecated in #11956)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point. 👌
However, IMHO, this could also be a separate PR as well, because it does not seem directly related to what is being done here. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but removing the package is not related to this PR either 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-requesting reviews just to make sure I didn't mess something up 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope of this PR: Is it just me or does this demo really need a fix for overflow scrolling? 🤔
In its current form it feels somewhat broken when part of the tree view is hidden when it could be scrollable. 🙈 🤷
Co-authored-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
@danilo-leal I cleaned up the spacing of both demos a little bit. Should be closer to the initial versions 🤔 Let me know what you think :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my PoV. 👍
Just need to fix the linting problems.
In this PR
https://deploy-preview-42149--material-ui.netlify.app/x