Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8600:Increase space below left checkbox preference #9125

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Mar 12, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare mcarare changed the title For #8600:Increase space below left checkbox preference For #8600:Increase space below left checkbox preference Mar 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #9125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9125   +/-   ##
=========================================
  Coverage     19.54%   19.54%           
  Complexity      511      511           
=========================================
  Files           329      329           
  Lines         13130    13130           
  Branches       1737     1737           
=========================================
  Hits           2566     2566           
+ Misses        10340    10339    -1     
- Partials        224      225    +1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/components/Search.kt 91.66% <0%> (-8.34%) 2% <0%> (ø)
...ix/home/sessioncontrol/SessionControlController.kt 66.95% <0%> (+0.86%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c862ca9...675406e. Read the comment docs.

@mcarare mcarare linked an issue Mar 18, 2020 that may be closed by this pull request
@@ -13,6 +13,7 @@
android:gravity="center_vertical"
android:paddingStart="8dp"
android:paddingBottom="8dp"
android:layout_marginBottom="8dp"
Copy link
Contributor

@BranescuMihai BranescuMihai Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding paddingTop=8dp instead, so that when you press it and the ripple effect takes place, the text and checkbox look centered in the button

EDIT: I just read the comments on the task, didn't realise they were connected.

LGTM!

@BranescuMihai BranescuMihai merged commit e4acabb into mozilla-mobile:master Mar 19, 2020
@mcarare mcarare deleted the 8600 branch June 3, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] show in private sessions button is too small
3 participants