Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] show in private sessions button is too small #8600

Closed
sblatz opened this issue Feb 20, 2020 · 3 comments · Fixed by #9125
Closed

[Bug] show in private sessions button is too small #8600

sblatz opened this issue Feb 20, 2020 · 3 comments · Fixed by #9125
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Settings implementation review needs:triage Issue needs triage P3 Some future sprint

Comments

@sblatz
Copy link
Contributor

sblatz commented Feb 20, 2020 •
edited by data-sync-user
Loading

image

┆Issue is synchronized with this Jira Task
@sblatz sblatz added 🐞 bug Crashes, Something isn't working, .. Feature:Settings labels Feb 20, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 20, 2020
@mcarare
Copy link
Contributor

mcarare commented Mar 11, 2020

@AmyYLee This was intentional, because the smaller space between the preference above indicates the fact that this is dependant on that. An alternative would be make it the same size, but indent the checkbox. What is your suggestion?

@mcarare mcarare self-assigned this Mar 11, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Mar 11, 2020

@AmyYLee This was intentional, because the smaller space between the preference above indicates the fact that this is dependant on that. An alternative would be make it the same size, but indent the checkbox. What is your suggestion?

@mcarare Hi, the suggestion was to give more space to the padding under "Show in private sessions" because it's very close to the bottom navigation and not the space above it.

mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 12, 2020
For mozilla-mobile#8600:Increase space below left checkbox preference
675406e
@AmyYLee AmyYLee added the P3 Some future sprint label Mar 13, 2020
@mcarare mcarare linked a pull request Mar 18, 2020 that will close this issue
For #8600:Increase space below left checkbox preference #9125
Merged
4 tasks
BranescuMihai pushed a commit that referenced this issue Mar 19, 2020
@BranescuMihai
For #8600:Increase space below left checkbox preference
e4acabb
@mcarare mcarare added the eng:qa:needed QA Needed label Mar 19, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 20, 2020

Hi, verified as fixed on the latest Nightly Build #20800605 from 3/20 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S6 (Android 7)
• OnePlus A3 (Android 6.0.1)

Comparison Nightly Build #20780606 3/18 VS Nightly Build #20800605 3/20 (Dropdown)

► ❌ Video Nightly Build from 3/18
20200320-084037

► ✔️ Video latest Nightly Build from 3/20
20200320-083932

@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 20, 2020
@liuche liuche mentioned this issue Mar 24, 2020
Closed
32 tasks
@mcarare mcarare mentioned this issue Mar 27, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Settings implementation review needs:triage Issue needs triage P3 Some future sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #8600:Increase space below left checkbox preference mcarare/fenix
4 participants
@sblatz @AmyYLee @mcarare @AndiAJ