-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments on lost fees due to bad debt or market forced removals #359
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d491f5c
feat: add comments
Jean-Grimal ac9dafc
Update src/interfaces/IMetaMorpho.sol
Jean-Grimal 70e4525
Apply suggestions from code review
Jean-Grimal ce04113
Update src/interfaces/IMetaMorpho.sol
Jean-Grimal 299229e
docs: apply suggestion
MerlinEgalite 1a49719
docs: rephrasing
MerlinEgalite 83b0bff
Update src/interfaces/IMetaMorpho.sol
Jean-Grimal 3da9d6b
Merge branch 'post-cantina' into feat/add-comments-on-lost-fees
MathisGD 949e596
docs: more accurate comment
MerlinEgalite 99651fd
Merge branch 'feat/add-comments-on-lost-fees' of github.com:morpho-la…
MerlinEgalite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the amount removed is bigger than the total amount of interest accrued by the other markets, the fee to accrue will be zero. It's worth mentioning it in the comment or anyway be more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can do it yes even though I think this is the general case