Add comments on lost fees due to bad debt or market forced removals #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Grimal
requested review from
a team,
adhusson,
Rubilmax,
QGarchery,
MerlinEgalite and
MathisGD
and removed request for
a team
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
Rubilmax
reviewed
Dec 22, 2023
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
MerlinEgalite
previously approved these changes
Dec 22, 2023
MathisGD
reviewed
Dec 22, 2023
Rubilmax
approved these changes
Dec 22, 2023
Rubilmax
previously approved these changes
Dec 22, 2023
Jean-Grimal
dismissed stale reviews from Rubilmax and MerlinEgalite
via
ce04113
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
Rubilmax
previously approved these changes
Dec 22, 2023
MerlinEgalite
previously approved these changes
Dec 22, 2023
QGarchery
reviewed
Dec 23, 2023
MerlinEgalite
dismissed stale reviews from Rubilmax and themself
via
299229e
Rubilmax
previously approved these changes
Dec 24, 2023
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
MathisGD
previously approved these changes
Dec 26, 2023
MathisGD
previously approved these changes
Dec 26, 2023
QGarchery
previously approved these changes
Dec 27, 2023
adhusson
reviewed
Dec 27, 2023
MerlinEgalite
previously approved these changes
Dec 27, 2023
…bs/morpho-blue-metamorpho into feat/add-comments-on-lost-fees
MerlinEgalite
dismissed stale reviews from QGarchery, MathisGD, and themself
via
99651fd
MerlinEgalite
approved these changes
Dec 27, 2023
MathisGD
approved these changes
Dec 27, 2023
adhusson
approved these changes
Dec 27, 2023
Merged
StErMi
reviewed
Dec 30, 2023
| @@ -145,6 +147,7 @@ interface IMetaMorphoBase { | |||
| /// @notice Warning: Anyone can supply on behalf of the vault so the call to `updateWithdrawQueue` that expects a | |||
| /// market to be empty can be griefed by a front-run. To circumvent this, the allocator can simply bundle a | |||
| /// reallocation that withdraws max from this market with a call to `updateWithdrawQueue`. | |||
| /// @dev Warning: Removing a market with supply will decrease the fee accrued until the next deposit/withdrawal. | |||
There was a problem hiding this comment.
If the amount removed is bigger than the total amount of interest accrued by the other markets, the fee to accrue will be zero. It's worth mentioning it in the comment or anyway be more specific.
There was a problem hiding this comment.
can do it yes even though I think this is the general case
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #337
Fixes https://cantina.xyz/ai/8409a0ce-6c21-4cc9-8ef2-bd77ce7425af/findings/5a81700d-ff95-422a-be37-e24f7e4d50a9