Merge pull request #73 from maximehuran/feature/few-changes

Change docker composer and reduce PHP Stan level
monsieurbiz · Aug 27, 2024 · 79606f4 · 79606f4
2 parents 73fd672 + 41e5d85
commit 79606f4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/Makefile b/Makefile
@@ -9,7 +9,7 @@ export COMPOSE_PROJECT_NAME=cms-page
 export MIGRATIONS_NAMESPACE=MonsieurBiz\\SyliusCmsPagePlugin\\Migrations
 export USER_UID=$(shell id -u)
 PLUGIN_NAME=sylius-${COMPOSE_PROJECT_NAME}-plugin
-COMPOSE=docker-compose
+COMPOSE=docker compose
 YARN=yarn
 
 ###

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,5 @@
 parameters:
-    level: max
+    level: 8
     paths:
         - %rootDir%/src/
 

diff --git a/src/Repository/PageRepository.php b/src/Repository/PageRepository.php
@@ -40,7 +40,6 @@ public function existsOneByChannelAndSlug(ChannelInterface $channel, ?string $lo
             ;
         }
 
-        /** @phpstan-ignore-next-line */
         $count = (int) $queryBuilder
             ->getQuery()
             ->getSingleScalarResult()
@@ -56,7 +55,6 @@ public function existsOneEnabledByChannelAndSlug(ChannelInterface $channel, ?str
             ->andWhere('p.enabled = true')
         ;
 
-        /** @phpstan-ignore-next-line */
         $count = (int) $queryBuilder
             ->getQuery()
             ->getSingleScalarResult()
@@ -70,7 +68,6 @@ public function existsOneEnabledByChannelAndSlug(ChannelInterface $channel, ?str
      */
     public function findOneEnabledBySlugAndChannelCode(string $slug, string $localeCode, string $channelCode): ?PageInterface
     {
-        /** @phpstan-ignore-next-line */
         return $this->createQueryBuilder('p')
             ->leftJoin('p.translations', 'translation')
             ->innerJoin('p.channels', 'channels')