Merge pull request #72 from maximehuran/feature/fix-sort-grid

We need a default sorting in grid to have sorting works
monsieurbiz · Aug 2, 2024 · 73fd672 · 73fd672
2 parents 46c0987 + 0a9727a
commit 73fd672
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 3 deletions.
diff --git a/src/Resources/config/sylius/grid.yaml b/src/Resources/config/sylius/grid.yaml
@@ -12,7 +12,13 @@ sylius_grid:
                         method: createListQueryBuilder
                         arguments: ["%locale%"]
             limits: [25, 50, 100, 200]
+            sorting:
+                id: desc
             fields:
+                id:
+                    type: string
+                    label: monsieurbiz_cms_page.ui.form.id
+                    sortable: ~
                 code:
                     type: string
                     label: monsieurbiz_cms_page.ui.form.code

diff --git a/src/Resources/translations/messages.en.yaml b/src/Resources/translations/messages.en.yaml
@@ -7,6 +7,7 @@ monsieurbiz_cms_page:
     pages_subheader: "CMS Page management"
     back_to_admin: "Back to admin"
     form:
+      id: 'ID'
       page_info: 'Page information'
       page_content: 'Page content'
       enabled: "Enabled"

diff --git a/src/Resources/translations/messages.fr.yaml b/src/Resources/translations/messages.fr.yaml
@@ -7,6 +7,7 @@ monsieurbiz_cms_page:
     pages_subheader: "Gestion des contenus CMS"
     back_to_admin: "Retour à l'admin"
     form:
+      id: 'ID'
       page_info: 'Informations de la page'
       page_content: 'Contenu de la page'
       enabled: "Activée"

diff --git a/src/Resources/translations/messages.pl.yaml b/src/Resources/translations/messages.pl.yaml
@@ -7,6 +7,7 @@ monsieurbiz_cms_page:
         pages_subheader: "Zarządzanie stronami CMS"
         back_to_admin: "Powrót do administracji"
         form:
+            id: 'ID'
             page_info: 'Informacje o stronie'
             page_content: 'Treść strony'
             enabled: "Włączone"

diff --git a/src/Routing/RequestContext.php b/src/Routing/RequestContext.php
@@ -82,7 +82,7 @@ private function prepareSlug(string $slug): string
         }
 
         // Remove the locale code which is at the beginning of the slug
-        return (string) preg_replace(sprintf('/^%s\//', $localeCode), '', $slug);
+        return (string) preg_replace(\sprintf('/^%s\//', $localeCode), '', $slug);
     }
 
     /**
@@ -97,6 +97,6 @@ public function __call(string $name, array $arguments)
             return \call_user_func($callback, ...$arguments);
         }
 
-        throw new Exception(sprintf('Method %s not found for class "%s"', $name, \get_class($this->decorated)));
+        throw new Exception(\sprintf('Method %s not found for class "%s"', $name, \get_class($this->decorated)));
     }
 }
diff --git a/src/Validator/Constraints/UniqueSlugByChannelValidator.php b/src/Validator/Constraints/UniqueSlugByChannelValidator.php
@@ -55,7 +55,7 @@ public function validate($value, Constraint $constraint): void
                         '%channel%' => $channel->getCode(),
                         '%locale%' => $translation->getLocale(),
                     ])
-                        ->atPath(sprintf('translations[%s].slug', $translation->getLocale()))
+                        ->atPath(\sprintf('translations[%s].slug', $translation->getLocale()))
                         ->addViolation()
                     ;
                 }