Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-3324 Upgrade CI Go to 1.22 and golangci-lint to 1.59.1. #1783

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

matthewdale
Copy link
Collaborator

GODRIVER-3324

Summary

  • Upgrade CI to Go 1.22.
  • Remove the "-go-1-XX" suffix from the OS matrix IDs to prevent losing Evergreen job history when we upgrade Go.
  • Upgrade golangci-lint to 1.59.1 and fix lint errors.
  • Change many instances of log.Fatal to log.Panic.
    • One of the new lint checks points out that calling log.Fatal after calling defer prevents the defer from running because log.Fatal exits the application immediately. In those cases, use log.Panic, which has the same logging behavior but panics instead, which still allows deferred calls to execute.

Background & Motivation

See previous PRs #1729 and #1730 that made the same change on the master branch.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added dependencies Pull requests that update a dependency file documentation Pull requests that update documentation or examples priority-3-low Low Priority PR for Review labels Aug 30, 2024
Copy link
Contributor

API Change Report

No changes found!

Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthewdale matthewdale merged commit ac03e73 into mongodb:v1 Sep 5, 2024
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Pull requests that update documentation or examples priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants