GODRIVER-3293 Upgrade golangci-lint to 1.59.1 and fix lint errors. #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
godriver3293-upgrade-lint
branch
from
dbde20d
to
b251d74
Compare
matthewdale
force-pushed
the
godriver3293-upgrade-lint
branch
from
b251d74
to
a47d652
Compare
API Change ReportNo changes found! |
qingyang-hu
approved these changes
Aug 12, 2024
| gocritic: | ||
| enabled-checks: | ||
| # Detects suspicious append result assignments. E.g. "b := append(a, 1, 2, 3)" | ||
| - appendAssign |
There was a problem hiding this comment.
Is it covered by default in the new version?
There was a problem hiding this comment.
Yes it is! I got a warning that the config is redundant:
WARN [linters_context] gocritic: no need to enable check "appendAssign": it's already enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3293
Summary
log.Fataltolog.Panic.log.Fatalafter callingdeferprevents thedeferfrom running becauselog.Fatalexits the application immediately. In those cases, uselog.Panic, which has the same logging behavior but panics instead, which still allows deferred calls to execute.Background & Motivation
Our current golangci-lint (v1.52.2) panics with Go 1.22. Upgrade it to latest (v1.59.1) to resolve the panic and to take advantage of improved lint checks.
This PR depends on #1730 to upgrade Go to 1.22 because golangci-lint v1.59.1 won't build with Go 1.20.