frontend: update lint checks to use all args instead of non-nil args #4524
Annotations
11 errors
Generate annotations:
frontend/dockerfile/run.go#L272
=== RUN TestIntegration
run.go:272: copied docker.io/amd64/busybox:latest@sha256:023917ec6a886d0e8e15f28fb543515a5fcd8d938edb091e8147db4efed388ee to local mirror localhost:44301/library/busybox:latest
time="2024-10-04T22:42:21Z" level=info msg="trying next host - response was http.StatusNotFound" host="localhost:44301"
run.go:272: copied docker.io/amd64/alpine:latest@sha256:25fad2a32ad1f6f510e528448ae1ec69a28ef81916a004d3629874104f8a7f70 to local mirror localhost:44301/library/alpine:latest
run.go:272: copied docker.io/amd64/debian:bullseye-20230109-slim@sha256:1acb06a0c31fb467eb8327ad361f1091ab265e0bf26d452dea45dcb0c0ea5e75 to local mirror localhost:40635/amd64/bullseye-20230109-slim:latest
--- FAIL: TestIntegration (0.07s)
|
Generate annotations:
frontend/dockerfile/sandbox.go#L135
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client
=== PAUSE TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client
=== CONT TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client
sandbox.go:135: stdout: /opt/containerd-alt-16/bin/containerd --config /tmp/bktest_containerd1766209069/config.toml
sandbox.go:135: stderr: /opt/containerd-alt-16/bin/containerd --config /tmp/bktest_containerd1766209069/config.toml
sandbox.go:138: > StartCmd 2024-10-04 22:42:53.655871909 +0000 UTC m=+32.975585296 /opt/containerd-alt-16/bin/containerd --config /tmp/bktest_containerd1766209069/config.toml
sandbox.go:138: time="2024-10-04T22:42:53Z" level=warning msg="containerd config version `1` has been deprecated and will be converted on each startup in containerd v2.0, use `containerd config migrate` after upgrading to containerd 2.0 to avoid conversion on startup"
sandbox.go:138: time="2024-10-04T22:42:53.676952515Z" level=info msg="starting containerd" revision=d2d58213f83a351ca8f528a95fbd145f5654e957 version=v1.6.33
sandbox.go:138: time="2024-10-04T22:42:53.699199846Z" level=info msg="loading plugin \"io.containerd.content.v1.content\"..." type=io.containerd.content.v1
sandbox.go:138: time="2024-10-04T22:42:53.699400449Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.devmapper\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.699429373Z" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.devmapper" error="devmapper not configured"
sandbox.go:138: time="2024-10-04T22:42:53.699444812Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.native\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.699583049Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.overlayfs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.699901833Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.aufs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.700872791Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.aufs\"..." error="aufs is not supported (modprobe aufs failed: exit status 1 \"modprobe: can't change directory to '/lib/modules': No such file or directory\\n\"): skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.700911903Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.zfs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.701098411Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.zfs\"..." error="path /tmp/bktest_containerd1766209069/root/io.containerd.snapshotter.v1.zfs must be a zfs filesystem to be used with the zfs snapshotter: skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.701118408Z" level=info msg="loading plugin \"io.containerd.metadata.v1.bolt\"..." type=io.containerd.metadata.v1
sandbox.go:138: time="2024-10-04T22:42:53.701286190Z" level=warning msg="could not use snapshotter devmapper in metadata plugin" error="devmapper not configured"
sandbox.go:138: time="2024-10-04T22:42:53.701307710Z" level=info msg="metadata content store policy set" policy=shared
sandbox.go:138: time="2024-10-04T22:42:53.704538616Z" level=info msg="loading plugin \"io.containerd.differ.v1.walking\"..." type=io.containerd.differ.v1
sandbox.go:138: time="2024-10-04T22:42:53.704585884Z" level=info msg="loading plugin \"io.containerd.event.v1.exchange\"..." type=io.containerd.event.v1
sandbox.go:138: time="2024-10-04T22:42:53.704603016Z" level=info msg="loading plugin \"io.containerd.gc.v1.scheduler\"..." type=io.containerd.gc.v1
sandbox.go:138: time="2024-10-04T22:42:53.704636208Z" level=info msg="loading plugin \"io.containerd.runtime.v1.linux\"..." type=io.containerd.runtime.v1
sandbox.go:138: time="2024-10-04T22:42:53.704808699Z" level
|
Generate annotations:
frontend/dockerfile/sandbox.go#L135
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin
=== PAUSE TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin
=== CONT TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin
sandbox.go:135: stdout: /opt/containerd-alt-16/bin/containerd --config /tmp/bktest_containerd1338914956/config.toml
sandbox.go:135: stderr: /opt/containerd-alt-16/bin/containerd --config /tmp/bktest_containerd1338914956/config.toml
sandbox.go:138: > StartCmd 2024-10-04 22:42:53.406535778 +0000 UTC m=+32.726249175 /opt/containerd-alt-16/bin/containerd --config /tmp/bktest_containerd1338914956/config.toml
sandbox.go:138: time="2024-10-04T22:42:53Z" level=warning msg="containerd config version `1` has been deprecated and will be converted on each startup in containerd v2.0, use `containerd config migrate` after upgrading to containerd 2.0 to avoid conversion on startup"
sandbox.go:138: time="2024-10-04T22:42:53.427733374Z" level=info msg="starting containerd" revision=d2d58213f83a351ca8f528a95fbd145f5654e957 version=v1.6.33
sandbox.go:138: time="2024-10-04T22:42:53.449025338Z" level=info msg="loading plugin \"io.containerd.content.v1.content\"..." type=io.containerd.content.v1
sandbox.go:138: time="2024-10-04T22:42:53.449204712Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.devmapper\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.449231271Z" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.devmapper" error="devmapper not configured"
sandbox.go:138: time="2024-10-04T22:42:53.449244035Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.native\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.449355422Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.overlayfs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.449642146Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.aufs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.450682241Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.aufs\"..." error="aufs is not supported (modprobe aufs failed: exit status 1 \"modprobe: can't change directory to '/lib/modules': No such file or directory\\n\"): skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.450710514Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.zfs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.450912981Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.zfs\"..." error="path /tmp/bktest_containerd1338914956/root/io.containerd.snapshotter.v1.zfs must be a zfs filesystem to be used with the zfs snapshotter: skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:42:53.450931455Z" level=info msg="loading plugin \"io.containerd.metadata.v1.bolt\"..." type=io.containerd.metadata.v1
sandbox.go:138: time="2024-10-04T22:42:53.451002287Z" level=warning msg="could not use snapshotter devmapper in metadata plugin" error="devmapper not configured"
sandbox.go:138: time="2024-10-04T22:42:53.451015261Z" level=info msg="metadata content store policy set" policy=shared
sandbox.go:138: time="2024-10-04T22:42:53.454231970Z" level=info msg="loading plugin \"io.containerd.differ.v1.walking\"..." type=io.containerd.differ.v1
sandbox.go:138: time="2024-10-04T22:42:53.454261856Z" level=info msg="loading plugin \"io.containerd.event.v1.exchange\"..." type=io.containerd.event.v1
sandbox.go:138: time="2024-10-04T22:42:53.454292994Z" level=info msg="loading plugin \"io.containerd.gc.v1.scheduler\"..." type=io.containerd.gc.v1
sandbox.go:138: time="2024-10-04T22:42:53.454339140Z" level=info msg="loading plugin \"io.containerd.runtime.v1.linux\"..." type=io.containerd.runtime.v1
sandbox.go:138: time="2024-10-04T22:42:53.454494158Z" le
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1554
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress
dockerfile_lint_test.go:1554: expected 1 warnings, received:
dockerfile_lint_test.go:1554:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1505
/src/frontend/dockerfile/dockerfile_lint_test.go:1554
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress (0.27s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1554
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client/warntype=progress
dockerfile_lint_test.go:1554: expected 1 warnings, received:
dockerfile_lint_test.go:1554:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1505
/src/frontend/dockerfile/dockerfile_lint_test.go:1554
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client/warntype=progress
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client/warntype=progress (0.18s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1406
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=unmarshal
dockerfile_lint_test.go:1406:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1406
/src/frontend/gateway/grpcclient/client.go:216
/src/client/build.go:58
/src/client/solve.go:296
/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
/usr/local/go/src/runtime/asm_amd64.s:1695
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=unmarshal
dockerfile_lint_test.go:1432:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1432
/src/frontend/dockerfile/dockerfile_lint_test.go:1558
Error: Should be true
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=unmarshal
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=unmarshal (0.05s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1554
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress#01
dockerfile_lint_test.go:1554: expected 1 warnings, received:
dockerfile_lint_test.go:1554:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1505
/src/frontend/dockerfile/dockerfile_lint_test.go:1554
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress#01
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress#01 (0.07s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1406
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=unmarshal#01
dockerfile_lint_test.go:1406:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1406
/src/frontend/gateway/grpcclient/client.go:216
/src/client/build.go:58
/src/client/solve.go:296
/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
/usr/local/go/src/runtime/asm_amd64.s:1695
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=unmarshal#01
dockerfile_lint_test.go:1432:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1432
/src/frontend/dockerfile/dockerfile_lint_test.go:1558
Error: Should be true
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=unmarshal#01
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=unmarshal#01 (0.04s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1554
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress#02
dockerfile_lint_test.go:1554: expected 1 warnings, received:
dockerfile_lint_test.go:1554:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1505
/src/frontend/dockerfile/dockerfile_lint_test.go:1554
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress#02
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=builtin/warntype=progress#02 (0.06s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1406
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client/warntype=unmarshal
dockerfile_lint_test.go:1406:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1406
/src/frontend/gateway/grpcclient/client.go:216
/src/client/build.go:58
/src/client/solve.go:296
/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
/usr/local/go/src/runtime/asm_amd64.s:1695
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client/warntype=unmarshal
dockerfile_lint_test.go:1432:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1432
/src/frontend/dockerfile/dockerfile_lint_test.go:1558
Error: Should be true
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client/warntype=unmarshal
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd-1.6/frontend=client/warntype=unmarshal (0.05s)
|
Test
Process completed with exit code 1.
|
Loading