frontend: update lint checks to use all args instead of non-nil args #4524
Annotations
11 errors
Generate annotations:
frontend/dockerfile/run.go#L272
=== RUN TestIntegration
run.go:272: copied docker.io/amd64/busybox:latest@sha256:023917ec6a886d0e8e15f28fb543515a5fcd8d938edb091e8147db4efed388ee to local mirror localhost:36445/library/busybox:latest
time="2024-10-04T22:42:39Z" level=info msg="trying next host - response was http.StatusNotFound" host="localhost:36445"
run.go:272: copied docker.io/amd64/alpine:latest@sha256:25fad2a32ad1f6f510e528448ae1ec69a28ef81916a004d3629874104f8a7f70 to local mirror localhost:36445/library/alpine:latest
run.go:272: copied docker.io/amd64/debian:bullseye-20230109-slim@sha256:1acb06a0c31fb467eb8327ad361f1091ab265e0bf26d452dea45dcb0c0ea5e75 to local mirror localhost:41349/amd64/bullseye-20230109-slim:latest
--- FAIL: TestIntegration (0.06s)
|
Generate annotations:
frontend/dockerfile/sandbox.go#L135
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=builtin
=== PAUSE TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=builtin
=== CONT TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=builtin
sandbox.go:135: stdout: /usr/bin/containerd --config /tmp/bktest_containerd2317200908/config.toml
sandbox.go:135: stderr: /usr/bin/containerd --config /tmp/bktest_containerd2317200908/config.toml
sandbox.go:138: > StartCmd 2024-10-04 22:44:10.937876374 +0000 UTC m=+92.881254914 /usr/bin/containerd --config /tmp/bktest_containerd2317200908/config.toml
sandbox.go:138: time="2024-10-04T22:44:10Z" level=warning msg="containerd config version `1` has been deprecated and will be converted on each startup in containerd v2.0, use `containerd config migrate` after upgrading to containerd 2.0 to avoid conversion on startup"
sandbox.go:138: time="2024-10-04T22:44:10.965317902Z" level=info msg="starting containerd" revision=472731909fa34bd7bc9c087e4c27943f9835f111 version=v1.7.21
sandbox.go:138: time="2024-10-04T22:44:10.999183312Z" level=info msg="loading plugin \"io.containerd.event.v1.exchange\"..." type=io.containerd.event.v1
sandbox.go:138: time="2024-10-04T22:44:10.999308887Z" level=info msg="loading plugin \"io.containerd.internal.v1.opt\"..." type=io.containerd.internal.v1
sandbox.go:138: time="2024-10-04T22:44:10.999367207Z" level=info msg="loading plugin \"io.containerd.warning.v1.deprecations\"..." type=io.containerd.warning.v1
sandbox.go:138: time="2024-10-04T22:44:10.999403334Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.blockfile\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:10.999506198Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.blockfile\"..." error="no scratch file generator: skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:10.999520965Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.devmapper\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:10.999536054Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.devmapper\"..." error="devmapper not configured: skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:10.999582390Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.native\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:10.999729106Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.overlayfs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:11.000035130Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.aufs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:11.000928085Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.aufs\"..." error="aufs is not supported (modprobe aufs failed: exit status 1 \"modprobe: can't change directory to '/lib/modules': No such file or directory\\n\"): skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:11.000986364Z" level=info msg="loading plugin \"io.containerd.snapshotter.v1.zfs\"..." type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:11.001391074Z" level=info msg="skip loading plugin \"io.containerd.snapshotter.v1.zfs\"..." error="path /tmp/bktest_containerd2317200908/root/io.containerd.snapshotter.v1.zfs must be a zfs filesystem to be used with the zfs snapshotter: skip plugin" type=io.containerd.snapshotter.v1
sandbox.go:138: time="2024-10-04T22:44:11.001463760Z" level=info msg="loading plugin \"io.containerd.content.v1.content\"..." type=io.containerd.content.v1
sandbox.go:138: time="2024-10-04T22:44:11.001674738Z" level=info msg="loading plugin \"io.containerd.metadata.v1.bolt\"..." type=io.containerd.metadata.v1
sandbox.go:138: time="2024-10-04T22:44:11.001768444Z" level=info msg="metadata content store policy set" policy=sha
|
Generate annotations:
frontend/dockerfile/sandbox.go#L135
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client
=== PAUSE TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client
=== CONT TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client
sandbox.go:135: stdout: /usr/bin/buildkitd --containerd-worker-gc=false --containerd-worker=true --containerd-worker-addr /tmp/bktest_containerd3122298895/containerd.sock --containerd-worker-labels=org.mobyproject.buildkit.worker.sandbox=true --oci-worker=false --config=/tmp/bktest_config4269096114/buildkitd.toml --root /tmp/bktest_buildkitd3200951503 --addr unix:///tmp/bktest_buildkitd3200951503/buildkitd.sock --debug
sandbox.go:135: stderr: /usr/bin/buildkitd --containerd-worker-gc=false --containerd-worker=true --containerd-worker-addr /tmp/bktest_containerd3122298895/containerd.sock --containerd-worker-labels=org.mobyproject.buildkit.worker.sandbox=true --oci-worker=false --config=/tmp/bktest_config4269096114/buildkitd.toml --root /tmp/bktest_buildkitd3200951503 --addr unix:///tmp/bktest_buildkitd3200951503/buildkitd.sock --debug
sandbox.go:138: > StartCmd 2024-10-04 22:44:10.722921741 +0000 UTC m=+92.666300310 /usr/bin/buildkitd --containerd-worker-gc=false --containerd-worker=true --containerd-worker-addr /tmp/bktest_containerd3122298895/containerd.sock --containerd-worker-labels=org.mobyproject.buildkit.worker.sandbox=true --oci-worker=false --config=/tmp/bktest_config4269096114/buildkitd.toml --root /tmp/bktest_buildkitd3200951503 --addr unix:///tmp/bktest_buildkitd3200951503/buildkitd.sock --debug
sandbox.go:138: time="2024-10-04T22:44:10Z" level=warning msg="failed to get disk size: no such file or directory"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=warning msg="failed to get disk size: no such file or directory"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=debug msg="could not read \"/tmp/bktest_buildkitd3200951503/net/cni\" for cleanup: open /tmp/bktest_buildkitd3200951503/net/cni: no such file or directory"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=debug msg="creating new network namespace h73uwjr16cv209q5byqf3isjo"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=debug msg="finished creating network namespace h73uwjr16cv209q5byqf3isjo"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=debug msg="finished setting up network namespace h73uwjr16cv209q5byqf3isjo"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=debug msg="remote introspection plugin filters" filters="[type==io.containerd.runtime.v1 type==io.containerd.runtime.v2]"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=info msg="found worker \"7zz7ix4haxyf22xyu61468rwh\", labels=map[org.mobyproject.buildkit.worker.containerd.namespace:buildkit org.mobyproject.buildkit.worker.containerd.uuid:19a02e6c-8aa1-4fe3-80ba-863bd2f9df10 org.mobyproject.buildkit.worker.executor:containerd org.mobyproject.buildkit.worker.hostname:06a740d5e0ee org.mobyproject.buildkit.worker.network:cni org.mobyproject.buildkit.worker.sandbox:true org.mobyproject.buildkit.worker.selinux.enabled:false org.mobyproject.buildkit.worker.snapshotter:overlayfs], platforms=[linux/amd64 linux/amd64/v2 linux/amd64/v3 linux/arm64 linux/riscv64 linux/ppc64le linux/s390x linux/386 linux/arm/v7 linux/arm/v6]"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=info msg="found 1 workers, default=\"7zz7ix4haxyf22xyu61468rwh\""
sandbox.go:138: time="2024-10-04T22:44:10Z" level=warning msg="currently, only the default worker can be used."
sandbox.go:138: time="2024-10-04T22:44:10Z" level=info msg="running server on /tmp/bktest_buildkitd3200951503/buildkitd.sock"
sandbox.go:138: time="2024-10-04T22:44:10Z" level=debug msg="session started" spanID=bd7ef06257c2cf53 traceID=844f56fbf5921585da3605bd0234e899
sandbox.go:138: time="2024-10-04T22:44:10Z" level=debug msg="new ref for local: pp4uvyzwurwmbcrjmiftwddx6" span="[internal] load build definition from Dockerfile" spanID=7cc59ad51147a8d4 traceID=dc8b3f5422ba2cabc5ddfb86c7ae9ac7
sandbox.go:138: time="20
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1554
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress
dockerfile_lint_test.go:1554: expected 1 warnings, received:
dockerfile_lint_test.go:1554:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1505
/src/frontend/dockerfile/dockerfile_lint_test.go:1554
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress (0.21s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1406
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal
dockerfile_lint_test.go:1406:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1406
/src/frontend/gateway/grpcclient/client.go:216
/src/client/build.go:58
/src/client/solve.go:296
/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
/usr/local/go/src/runtime/asm_amd64.s:1695
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal
dockerfile_lint_test.go:1432:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1432
/src/frontend/dockerfile/dockerfile_lint_test.go:1558
Error: Should be true
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal (0.05s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1554
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress#01
dockerfile_lint_test.go:1554: expected 1 warnings, received:
dockerfile_lint_test.go:1554:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1505
/src/frontend/dockerfile/dockerfile_lint_test.go:1554
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress#01
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress#01 (0.10s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1554
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=builtin/warntype=progress
dockerfile_lint_test.go:1554: expected 1 warnings, received:
dockerfile_lint_test.go:1554:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1505
/src/frontend/dockerfile/dockerfile_lint_test.go:1554
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=builtin/warntype=progress
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=builtin/warntype=progress (0.22s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1406
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal#01
dockerfile_lint_test.go:1406:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1406
/src/frontend/gateway/grpcclient/client.go:216
/src/client/build.go:58
/src/client/solve.go:296
/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
/usr/local/go/src/runtime/asm_amd64.s:1695
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal#01
dockerfile_lint_test.go:1432:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1432
/src/frontend/dockerfile/dockerfile_lint_test.go:1558
Error: Should be true
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal#01
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal#01 (0.06s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1554
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress#02
dockerfile_lint_test.go:1554: expected 1 warnings, received:
dockerfile_lint_test.go:1554:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1505
/src/frontend/dockerfile/dockerfile_lint_test.go:1554
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress#02
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=progress#02 (0.10s)
|
Generate annotations:
frontend/dockerfile/dockerfile_lint_test.go#L1406
=== RUN TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal#02
dockerfile_lint_test.go:1406:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1406
/src/frontend/gateway/grpcclient/client.go:216
/src/client/build.go:58
/src/client/solve.go:296
/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
/usr/local/go/src/runtime/asm_amd64.s:1695
Error: Not equal:
expected: 1
actual : 0
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal#02
dockerfile_lint_test.go:1432:
Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1432
/src/frontend/dockerfile/dockerfile_lint_test.go:1558
Error: Should be true
Test: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal#02
--- FAIL: TestIntegration/TestInvalidDefaultArgInFrom/worker=containerd/frontend=client/warntype=unmarshal#02 (0.05s)
|
Test
Process completed with exit code 1.
|
Loading