Add NDK r26 to CI image #38975
Merged
Add NDK r26 to CI image #38975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheney-W
added
the
category:infrastructure
Cheney-W
previously approved these changes
May 28, 2024
vicroms
added
the
depends:vm-update
|
Should we add r26 or just outright replace r25? |
Add only. Immediate replacement will break CI. You also need #35851 minus its NDK download. But once the NDK is available (this PR), #35851 can simply include a change to override ANDROID_NDK_HOME in the pipeline. Then that PR could be ready to review and to merge to make the actual switch. And the old NDK could be removed after that. And in the meantime you may think about raising the Android API level to 24 (which means devices running Android 7.0, available since 2016) together wth the NDK switch. It will reduce CI validity for users targeting older devices. But it will significantly increase overall CI coverage. See ci.baseline.txt changes in the other PR. |
BillyONeal
removed
depends:vm-update
BillyONeal
approved these changes
Jun 7, 2024
|
Done, thanks! |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jun 9, 2024
Add NDK r26 to CI image (microsoft#38975)
7 tasks
BillyONeal
pushed a commit
that referenced
this pull request
Jun 17, 2024
Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=103938&view=results. ``` PASSING, REMOVE FROM FAIL LIST: c4core:arm-neon-android PASSING, REMOVE FROM FAIL LIST: botan:arm-neon-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm-neon-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm-neon-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm-neon-android PASSING, REMOVE FROM FAIL LIST: libcoro:arm-neon-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm-neon-android PASSING, REMOVE FROM FAIL LIST: stx:arm-neon-android PASSING, REMOVE FROM FAIL LIST: yoga:arm-neon-android PASSING, REMOVE FROM FAIL LIST: c4core:x64-android PASSING, REMOVE FROM FAIL LIST: botan:x64-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:x64-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:x64-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x64-android PASSING, REMOVE FROM FAIL LIST: libcoro:x64-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:x64-android PASSING, REMOVE FROM FAIL LIST: stx:x64-android PASSING, REMOVE FROM FAIL LIST: yoga:x64-android PASSING, REMOVE FROM FAIL LIST: c4core:arm64-android PASSING, REMOVE FROM FAIL LIST: botan:arm64-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm64-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm64-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm64-android PASSING, REMOVE FROM FAIL LIST: libcoro:arm64-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm64-android PASSING, REMOVE FROM FAIL LIST: stx:arm64-android PASSING, REMOVE FROM FAIL LIST: yoga:arm64-android ``` Added `c4core` to `ci.baseline.txt` by #29406, which has been fixed by #39287. Added `botan` to `ci.baseline.txt` by #37252, which has been fixed by #38975. Added `concurrencpp` to `ci.baseline.txt` by #29406, which may have been fixed by #39160. Added `cppgraphqlgen` to `ci.baseline.txt` by #29406, which may have been fixed by #38975. Added `graphicsmagick` to `ci.baseline.txt` by #29406, which has been fixed by #39210. Added `libcoro` to `ci.baseline.txt` by #30623, which may have been fixed by #38975. Added `ms-ifc-sdk` to `ci.baseline.txt` by #35972, which may have been fixed by #39210. Added `stx` to `ci.baseline.txt` by #29406, which may have been fixed by #38975. Added `yoga` to `ci.baseline.txt` by #37507, which may have been fixed by #38975.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.