Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yoga] Update to 3.0.2 #37507

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

waywardmonkeys
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@waywardmonkeys
Copy link
Contributor Author

I think the Android failures here are NDK 25 vs 26. Not positive though.

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 18, 2024
@FrankXie05
Copy link
Contributor

Error form CI:

FAILED: yoga/CMakeFiles/yogacore.dir/YGValue.cpp.o 
/android-ndk-r25c/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --target=x86_64-none-linux-android21 --sysroot=/android-ndk-r25c/toolchains/llvm/prebuilt/linux-x86_64/sysroot -DDEBUG -I/mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/.. -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -frtti -fexceptions  -fPIC   -fno-limit-debug-info    -std=gnu++20 -fPIC -fvisibility=hidden -fno-omit-frame-pointer -fexceptions -Wall -Werror -fno-rtti -MD -MT yoga/CMakeFiles/yogacore.dir/YGValue.cpp.o -MF yoga/CMakeFiles/yogacore.dir/YGValue.cpp.o.d -o yoga/CMakeFiles/yogacore.dir/YGValue.cpp.o -c /mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/YGValue.cpp
In file included from /mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/YGValue.cpp:9:
/mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/../yoga/numeric/Comparison.h:19:33: error: no type named 'floating_point' in namespace 'std'
constexpr bool isUndefined(std::floating_point auto value) {
                           ~~~~~^
/mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/../yoga/numeric/Comparison.h:23:31: error: no type named 'floating_point' in namespace 'std'
constexpr bool isDefined(std::floating_point auto value) {
                         ~~~~~^
/mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/../yoga/numeric/Comparison.h:36:10: error: no type named 'floating_point' in namespace 'std'
    std::floating_point auto a,
    ~~~~~^
/mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/../yoga/numeric/Comparison.h:37:10: error: no type named 'floating_point' in namespace 'std'
    std::floating_point auto b) {
    ~~~~~^
/mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/../yoga/numeric/Comparison.h:45:10: error: no type named 'floating_point' in namespace 'std'
    std::floating_point auto a,
    ~~~~~^
/mnt/vcpkg-ci/b/yoga/src/v3.0.2-e6d37b705c.clean/yoga/../yoga/numeric/Comparison.h:46:10: error: no type named 'floating_point' in namespace 'std'
    std::floating_point auto b) {
    ~~~~~^
6 errors generated.

install-x64-android-dbg-out.log

@waywardmonkeys
Copy link
Contributor Author

Yes and those are features in C++20, which is enabled in the build flags. Also, upstream Yoga has CI jobs for Android (but on NDK 26).

@FrankXie05
Copy link
Contributor

@waywardmonkeys Sorry, currently we have not updated to 26. We can add this port of arm triplets to ci.baseline.txt,

Mark as failing on Android as it seems to require a newer NDK.
@waywardmonkeys
Copy link
Contributor Author

@FrankXie05 I made that update, so I think this is okay to go?

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Mar 29, 2024
@BillyONeal BillyONeal merged commit 27dad96 into microsoft:master Mar 29, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks!

@waywardmonkeys waywardmonkeys deleted the update-yoga branch March 31, 2024 11:44
BillyONeal pushed a commit that referenced this pull request Jun 17, 2024
Passing on
https://dev.azure.com/vcpkg/public/_build/results?buildId=103938&view=results.
```
PASSING, REMOVE FROM FAIL LIST: c4core:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: botan:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: libcoro:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: stx:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: yoga:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: c4core:x64-android
PASSING, REMOVE FROM FAIL LIST: botan:x64-android
PASSING, REMOVE FROM FAIL LIST: concurrencpp:x64-android
PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:x64-android
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x64-android
PASSING, REMOVE FROM FAIL LIST: libcoro:x64-android
PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:x64-android
PASSING, REMOVE FROM FAIL LIST: stx:x64-android
PASSING, REMOVE FROM FAIL LIST: yoga:x64-android
PASSING, REMOVE FROM FAIL LIST: c4core:arm64-android
PASSING, REMOVE FROM FAIL LIST: botan:arm64-android
PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm64-android
PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm64-android
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm64-android
PASSING, REMOVE FROM FAIL LIST: libcoro:arm64-android
PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm64-android
PASSING, REMOVE FROM FAIL LIST: stx:arm64-android
PASSING, REMOVE FROM FAIL LIST: yoga:arm64-android
```

Added `c4core` to `ci.baseline.txt` by #29406, which has been fixed by
#39287.
Added `botan` to `ci.baseline.txt` by #37252, which has been fixed by
#38975.
Added `concurrencpp` to `ci.baseline.txt` by #29406, which may have been
fixed by #39160.
Added `cppgraphqlgen` to `ci.baseline.txt` by #29406, which may have
been fixed by #38975.
Added `graphicsmagick` to `ci.baseline.txt` by #29406, which has been
fixed by #39210.
Added `libcoro` to `ci.baseline.txt` by #30623, which may have been
fixed by #38975.
Added `ms-ifc-sdk` to `ci.baseline.txt` by #35972, which may have been
fixed by #39210.
Added `stx` to `ci.baseline.txt` by #29406, which may have been fixed by
#38975.
Added `yoga` to `ci.baseline.txt` by #37507, which may have been fixed
by #38975.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants