-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yoga] Update to 3.0.2 #37507
Merged
Merged
[yoga] Update to 3.0.2 #37507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the Android failures here are NDK 25 vs 26. Not positive though. |
FrankXie05
added
the
category:port-update
The issue is with a library, which is requesting update new revision
label
Mar 18, 2024
Error form CI:
|
Yes and those are features in C++20, which is enabled in the build flags. Also, upstream Yoga has CI jobs for Android (but on NDK 26). |
@waywardmonkeys Sorry, currently we have not updated to 26. We can add this port of arm triplets to |
waywardmonkeys
force-pushed
the
update-yoga
branch
from
March 22, 2024 12:27
c3ef891
to
49135b4
Compare
Mark as failing on Android as it seems to require a newer NDK.
waywardmonkeys
force-pushed
the
update-yoga
branch
from
March 22, 2024 16:48
49135b4
to
25f9aca
Compare
@FrankXie05 I made that update, so I think this is okay to go? |
FrankXie05
approved these changes
Mar 29, 2024
Thanks! |
7 tasks
BillyONeal
pushed a commit
that referenced
this pull request
Jun 17, 2024
Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=103938&view=results. ``` PASSING, REMOVE FROM FAIL LIST: c4core:arm-neon-android PASSING, REMOVE FROM FAIL LIST: botan:arm-neon-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm-neon-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm-neon-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm-neon-android PASSING, REMOVE FROM FAIL LIST: libcoro:arm-neon-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm-neon-android PASSING, REMOVE FROM FAIL LIST: stx:arm-neon-android PASSING, REMOVE FROM FAIL LIST: yoga:arm-neon-android PASSING, REMOVE FROM FAIL LIST: c4core:x64-android PASSING, REMOVE FROM FAIL LIST: botan:x64-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:x64-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:x64-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x64-android PASSING, REMOVE FROM FAIL LIST: libcoro:x64-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:x64-android PASSING, REMOVE FROM FAIL LIST: stx:x64-android PASSING, REMOVE FROM FAIL LIST: yoga:x64-android PASSING, REMOVE FROM FAIL LIST: c4core:arm64-android PASSING, REMOVE FROM FAIL LIST: botan:arm64-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm64-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm64-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm64-android PASSING, REMOVE FROM FAIL LIST: libcoro:arm64-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm64-android PASSING, REMOVE FROM FAIL LIST: stx:arm64-android PASSING, REMOVE FROM FAIL LIST: yoga:arm64-android ``` Added `c4core` to `ci.baseline.txt` by #29406, which has been fixed by #39287. Added `botan` to `ci.baseline.txt` by #37252, which has been fixed by #38975. Added `concurrencpp` to `ci.baseline.txt` by #29406, which may have been fixed by #39160. Added `cppgraphqlgen` to `ci.baseline.txt` by #29406, which may have been fixed by #38975. Added `graphicsmagick` to `ci.baseline.txt` by #29406, which has been fixed by #39210. Added `libcoro` to `ci.baseline.txt` by #30623, which may have been fixed by #38975. Added `ms-ifc-sdk` to `ci.baseline.txt` by #35972, which may have been fixed by #39210. Added `stx` to `ci.baseline.txt` by #29406, which may have been fixed by #38975. Added `yoga` to `ci.baseline.txt` by #37507, which may have been fixed by #38975.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-update
The issue is with a library, which is requesting update new revision
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --all
and committing the result.