[LogBox] Add NSWindow based version #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
commented
Nov 3, 2020
| CGPoint touchLocation = [self.view convertPoint:touch.locationInWindow fromView:nil]; | ||
| // -[NSView hitTest:] takes coordinates in a view's superview coordinate system. | ||
| // The assumption here is that a RCTUIView/RCTSurfaceView will always have a superview. | ||
| CGPoint touchLocation = [self.view.superview convertPoint:touch.locationInWindow fromView:nil]; |
There was a problem hiding this comment.
I suspect this issue never arose before because previously the only superview (RCTRootView) would have the same coordinate system.
|
The navigation buttons in the header not responding appears to be due to Or perhaps that the touchable view that wraps it is too small. |
tom-un
requested changes
Nov 4, 2020
ghost
added
|
The issue with the navigation buttons was an actual issue with coordinate translation, which is fixed now 👍 |
|
Unsure why I was seeing a source-map issue before, seems to work fine:
|
|
@tom-un This should be good to go. |
tom-un
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #621
Please select one of the following
Summary
LogBox is the preferred way to view warnings/errors in v0.63.0.
Changelog
[macOS] [Added] - NSWindow based version of LogBox
TODO
Still minor things to do, but the meat of the patch can be reviewed.
Test Plan
Microsoft Reviewers: Open in CodeFlow