v0.63 merge TODOs

[alloy]

For once #613 is merged.

• Get Android patches to apply and work as expected and/or move them out of this repo. This includes the Folly, double-conversion, and possible other vendored libs in the root of the repo. Rebasing android patches over RN63 #641

• Update react-native-macos-init:

  • The Podfile needs reconciliation with with upstream and RNTester
  • Ensure the user can enable hermes

• Go through all TODO(macOS v0.63) instances and verify new behaviour

  • facebook@fb8f5ea 8a20e2c

• Ensure the CircleCI nightly job isn't ran

• RNTester/Podfile:

  • require_relative '../scripts/react_native_pods'
  • use_flipper!
  • Change macOS targets to have deployment target of 10.13 (need newer hermes release) depends on [podspec] Build v0.4.x for macOS arm64 facebook/hermes#351. The artefacts need testing on a arm64 DTK.

• Libraries/Components/View/ReactNativeViewViewConfig.js:
  Do platform === ios checks need macOS as well?

• Libraries/Pressability/__tests__/Pressability-test.js:
  does this still fail: is called independent of preceding long touch gesture

• facebook@5394c90:
  Should we remove our addition to RCTTextAttributes? Various post-0.63-merge TODOs #631

• Libraries/Text/TextInput/Singleline/RCTUITextField.m:
  Do we still need to disable scrollEnabled on macOS? facebook@827b1fe Various post-0.63-merge TODOs #631

• React/Base/RCTTouchHandler.m:
  Does - (NSInteger)_eventWithNumber:(NSInteger)touchID still need to be an extracted method? Was it shared previously? [defork] Remove unnecessary refactor #625

• React/Base/RCTUtils.m:
  Does RCTForceTouchAvailable still need a iOS (10) guard? Remove outdated version guards #626

• React/CoreModules/CoreModulesPlugins.mm:
  Remove guard around RCTLogBoxCls Moving this to Enable previously disabled core turbo modules #627

• React/CxxBridge/RCTCxxBridge.mm:
  Where did this change move? 150f935#diff-a2a67635fffd7b690d14dc17ae563a71R933 Set correct HMR client platform #628

• React/Views/RCTView.m:
  Do we still need savedTraitCollection in displayLayer:?

  • 5bff60f#diff-82cd0f8fb7478261a85ac686ac07be50R793-R801
  • 5bff60f#diff-82cd0f8fb7478261a85ac686ac07be50R814-R821
    No longer needed, as per @tom-un’s comment below.

• Revisit the code-sharing between iOS and macOS PlatformColorValueTypes here 5065f58 e030009

• Is the naming of these alternate color names important? 21c189d
  Apparently not v0.63 sync from upstream #613 (comment)

• Image in RNTester doesn't load. The following message is logged:
  Reloading image http://192.168.1.35:8081/assets/node_modules/react-native-macos/Libraries/NewAppScreen/components/logo.png?platform=macos&hash=47ce6e77f039020ee2e76a10c1e988e9 as size {918, nan} Fixed by Fix RCTImageView not rendering images #637.

• LogBox does not have a working full screen version. [LogBox] Add NSWindow based version #645

Not now

• Should we run clang-format as per upstream? facebook@d0871d0

  • Should probably do this last so we can easily merge in master
  • Ensure it also runs on cpp files
  • Add a git/CI hook to ensure files are prettified?
  • Currently upstream master is not formatted either, so doesn't seem like the right time. Asking upstream maintainers what their plans are.

• Libraries/PushNotificationIOS/RCTPushNotificationManager.mm:
  old deprecated macOS ifdef'ed code replaced by: RCTPromiseResolveValueForUNNotificationSettings

• Libraries/PushNotificationIOS/RCTPushNotificationManager.mm:
  use UUUserNotificationCenter on macOS in removeAllDeliveredNotifications, removeDeliveredNotifications, getDeliveredNotifications

[alloy]

@tom-un Do you recall why you didn’t move these iOS changes upstream in your (dynamic) color changes?

• 5bff60f#diff-82cd0f8fb7478261a85ac686ac07be50R793-R801
• 5bff60f#diff-82cd0f8fb7478261a85ac686ac07be50R814-R821

[tom-un]

It was per this code review feedback from nscoding: facebook#27908 (comment)

And resulted in this commit by me: tom-un@7a4629b

In short: in the react-native-macos fork, and in my initial PR upstream, in -[RCTView displayLayer:] needed to get a "flattened" color via _backgroundColor.CGColor using the correct traits. In react-native-macos it was doing a [UITraitCollection setCurrentTraitCollection:[self traitCollection]] , call _backgroundColor.CGColor, then restore UITraitCollection via [UITraitCollection setCurrentTraitCollection:savedTraitCollection]. Nscodings suggestion was to use [_backgroundColor resolvedColorWithTraitCollection:self.traitCollection].CGColor instead so that's what's upstream.

[alloy]

@tom-un Ok, so if I understand correctly we now have a iOS specific solution upstream and still need the platform guard in our fork with your previous change? It sounds like the upstream version should just use the change you previously had and then we can get rid of the change in our fork, no? Scratch that, I lost track of your previous change also being an iOS only change.