fix(Types): ShorthandCollection

[assuncaocharles]

Pull request checklist

• Addresses an existing issue: Fixes ShorthandCollection does not contain proper definition fluent-ui-react#1664
• Include a change request file using $ yarn change

Description of changes

In #1605 was done an update for ShorthandCollection but it was not fully complete:

export interface ToolbarProps {
  /** Shorthand array of props for Toolbar. */
  items?: ShorthandCollection<ToolbarItemProps, ToolbarItemShorthandKinds>
}

It's not enough because for kind="divider" we should have ToolbarDividerProps.

This PR implements the proposed solution:

export interface ToolbarProps {
  /** Shorthand array of props for Toolbar. */
  items?: ShorthandCollection<ToolbarItemProps,  {
    item: ToolbarItemProps,
    divider: ToolbarDividerProps
  }>
}

To achieve that the ShorthandCollection type had to be changed to:

type ShorthandCollection<P, K = Record<string, {}>> = ShorthandValue<
  P & { kind?: keyof K } & Partial<K[keyof K]>
>[];

And alternative solution that can better is to create a new type:

type ShorthandCollection<P, K = never> = ShorthandValue<P>[]

type ShorthandCollectionWithKind<P, K = never> = ShorthandValue<
  P & { kind?: keyof K } & { K[keyof K] }
>[]

And then replace the places where ShorthandCollection are used together with kind.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

Microsoft Reviewers: Open in CodeFlow

[size-auditor]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 73cbfd0c0d41af4839d32070f2b6134cc4b3f471 (build)

[assuncaocharles]

@layershifter

export type ShorthandCollection<P, K = Record<string, {}>> = ShorthandValue<
  P & { kind?: keyof K } & Partial<K[keyof K]>
>[];

It works, what you think about?

[assuncaocharles]

@layershifter added the solution we agreed.