Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

ShorthandCollection does not contain proper definition #1664

Open
layershifter opened this issue Jul 17, 2019 · 0 comments
Open

ShorthandCollection does not contain proper definition #1664

layershifter opened this issue Jul 17, 2019 · 0 comments
Labels
vsts Paired with ticket in vsts

Comments

@layershifter
Copy link
Member

Bug Report

#1634 (review)

In #1605 was done an update for ShorthandCollection but it was not fully complete:

export interface ToolbarProps {
  /** Shorthand array of props for Toolbar. */
  items?: ShorthandCollection<ToolbarItemProps, ToolbarItemShorthandKinds>
}

It's not enough because for kind="divider" we should have ToolbarDividerProps.

Proposed solution

export interface ToolbarProps {
  /** Shorthand array of props for Toolbar. */
  items: ShorthandCollection<ToolbarItemProps, ToolbarItemShoerthandKinds, {
    item: ToolbarItemProps,
    divider: ToolbarDividerProps
  }>
}

Version

master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

2 participants