This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[Lib] Fallback lib change #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612 and
ryanisgrig
7 tasks
lzc850612
suggested changes
Jul 30, 2019
...harp/microsoft.bot.builder.solutions/microsoft.bot.builder.solutions/Dialogs/RouterDialog.cs
Outdated
Show resolved
Hide resolved
|
@lauren-mills can you take a look at the RouterDialog change? turns out we still need to do something because the SDK will swallow the Empty DialogTurnStatus result so we have to define our own TurnStatus to achieve what we want |
darrenj
reviewed
Jul 31, 2019
lib/csharp/microsoft.bot.builder.skills/Microsoft.Bot.Builder.Skills/SkillDialog.cs
Outdated
Show resolved
Hide resolved
lauren-mills
approved these changes
Jul 31, 2019
lzc850612
suggested changes
Jul 31, 2019
lib/csharp/microsoft.bot.builder.skills/Microsoft.Bot.Builder.Skills/SkillDialog.cs
Outdated
Show resolved
Hide resolved
lzc850612
approved these changes
Aug 1, 2019
lzc850612
pushed a commit
that referenced
this pull request
Aug 2, 2019
* [Part 1, lib change in future branch] Add fallback event support (#1875) * add fallback events in lib * update with new design * fix warning * fix warning * fix issue * fix indentation * remove dll * fix comments * fix warning * fix as comments * fix after discussion * fix comments * remove extra line * fix as comment * [Lib] Fallback lib change (#1976) * simplify lib change * fix as comments * fix as comments * fix as comments * fix merge error
DingmaomaoBJTU
added a commit
that referenced
this pull request
Aug 9, 2019
* [Part 1, lib change in future branch] Add fallback event support (#1875) * add fallback events in lib * update with new design * fix warning * fix warning * fix issue * fix indentation * remove dll * fix comments * fix warning * fix as comments * fix after discussion * fix comments * remove extra line * fix as comment * fallback rule in email and VA * add calendar support * fix as comments * [Lib] Fallback lib change (#1976) * simplify lib change * fix as comments * fix as comments * fix as comments * update lib * fix comments and upgrade to preview pkg * fix comments * add doc * retry build * add nuget feed * fix issue * trigger a new one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
[Part 1] #1598 Remove "do you want to hear more" type prompts from Skills
Changes
Simplify lib code per comments
Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General
Bots
.lufiles and validated that deployment is successfulDeployment Scripts