This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612 and
ryanisgrig
July 29, 2019 11:26
DingmaomaoBJTU
changed the title
[Email & VA] Fallback rule support
[Skills& VA] Fallback rule support
Jul 29, 2019
lauren-mills
suggested changes
Jul 29, 2019
templates/Virtual-Assistant-Template/csharp/Sample/VirtualAssistantSample/Dialogs/MainDialog.cs
Outdated
Show resolved
Hide resolved
templates/Virtual-Assistant-Template/csharp/Sample/VirtualAssistantSample/Dialogs/MainDialog.cs
Outdated
Show resolved
Hide resolved
...al-Assistant-Template/csharp/Sample/VirtualAssistantSample/Services/SkillIntentRecognizer.cs
Show resolved
Hide resolved
...irtual-Assistant-Template/csharp/Sample/VirtualAssistantSample/VirtualAssistantSample.csproj
Outdated
Show resolved
Hide resolved
lauren-mills
approved these changes
Aug 5, 2019
lzc850612
suggested changes
Aug 5, 2019
skills/src/csharp/calendarskill/calendarskill/CalendarSkill.csproj
Outdated
Show resolved
Hide resolved
templates/Virtual-Assistant-Template/csharp/VirtualAssistantTemplate.sln
Outdated
Show resolved
Hide resolved
templates/Virtual-Assistant-Template/csharp/VirtualAssistantTemplate.sln
Outdated
Show resolved
Hide resolved
pr-triage
bot
added
PR: reviewed-changes-requested
and removed
PR: reviewed-approved
labels
Aug 5, 2019
lzc850612
approved these changes
Aug 7, 2019
KayMKM
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
[Part 2] Close #1598 Remove "do you want to hear more" type prompts from Skills
Changes
Tests
Menual tested all possible senarios.
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General
Bots
.lu
files and validated that deployment is successfulDeployment Scripts