Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[Skills& VA] Fallback rule support #1971

Merged
merged 8 commits into from
Aug 8, 2019
Merged

Conversation

DingmaomaoBJTU
Copy link
Contributor

@DingmaomaoBJTU DingmaomaoBJTU commented Jul 29, 2019

Purpose

[Part 2] Close #1598 Remove "do you want to hear more" type prompts from Skills

Changes

  1. Add fallback event send & handle in Email/Calendar skill, tested
  2. Add fallback event redispatch handle logic in VA

Tests

Menual tested all possible senarios.

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@DingmaomaoBJTU DingmaomaoBJTU changed the title [Email & VA] Fallback rule support [Skills& VA] Fallback rule support Jul 29, 2019
@pr-triage pr-triage bot removed the PR: unreviewed label Aug 7, 2019
@DingmaomaoBJTU DingmaomaoBJTU merged commit 29bc29a into future Aug 8, 2019
@pr-triage pr-triage bot added merged and removed PR: unreviewed labels Aug 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the qiowu/FallbackRule_VA branch August 8, 2019 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants